Re: [PATCH proxmox{,-backup} v4 0/8] fix sync level updates for chunk store

[Robert Obkircher <r.obkircher@proxmox.com>]

Looks good to me now. I briefly tested that the syncing message is
printed when switching away from the Filesystem sync level.

The only minor nit would be that the single quotes in the last commit
are redundant, because :? already adds double quotes around the path.

Reviewed-by: Robert Obkircher <r.obkircher@proxmox.com>
Tested-by: Robert Obkircher <r.obkircher@proxmox.com>

On 14.05.26 10:05, Christian Ebner wrote:
> Currently the sync level configured for a datastore is only
> propagated to the chunk store on first lookup, when the chunk
> store instance is created. Updating the sync level in the tuning
> options does invalidate the cached datastore entry, does however
> not re-instantiate the chunk store, to avoid dropping the locks
> acquired via the process locker. This means however the sync level
> on the chunk store is not updated.
>
> Fixed by storing the chunk store state inside the mutex, already
> present for syncing up concurrent access to the chunk store. This
> also improves the code style and fixes a few smaller issues
> encountered.
>
> Changes since version 3 (thanks @Robert for feedback!):
> - Avoid premature dropping of chunk store mutex guard on cache inserts
> - Drop leftover Arc wrapping from previous iteration of the patch series,
>   combine locking method calls into single lines.
> - Log chunk store base path on syncfs
> - Drop unneeded error conversion in tuning option parsing helper
>
> Changes since version 2:
> - Include additional code cleanups
>
> Changes since version 1 (thanks @Robert for feedback!):
> - Fix lost sync level update, move implementation into chunk store
>   instead
> - Only try ensuring the sync level if it actually changed and fix race
>   window by taking the mutex guard for the check.
> - Avoid Arc for chunk store mutex, it can be shared by reference
> - Fixed typo
>
>
> proxmox:
>
> Christian Ebner (1):
>   pbs-api-types: derive FromStr for DatastoreTuning parsing
>
>  pbs-api-types/src/datastore.rs | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
>
> proxmox-backup:
>
> Christian Ebner (7):
>   datastore: GC: avoid double parsing of datastore tuning options
>   pbs-config/datastore: add common helper for parsing tuning options
>   datastore: restrict chunk store mutex scope to crate only
>   datastore: avoid useless double borrowing of datastore
>   datastore: move try_ensure_sync_level() implementation to chunk store
>   datastore: fix sync level update propagation to chunk store
>   chunk store: include filesystem backing path in log output
>
>  pbs-config/src/datastore.rs                   |  7 +-
>  pbs-datastore/src/chunk_store.rs              | 82 ++++++++++++++-----
>  pbs-datastore/src/datastore.rs                | 65 ++++++---------
>  .../src/local_datastore_lru_cache.rs          |  9 +-
>  src/api2/config/datastore.rs                  | 12 +--
>  5 files changed, 100 insertions(+), 75 deletions(-)
>
>
> Summary over all repositories:
>   6 files changed, 110 insertions(+), 75 deletions(-)
>