Re: [PATCH v1 proxmox-backup] config: invalidate CachedUserInfo after ACL changes

[Christian Ebner <c.ebner@proxmox.com>]

On 8/31/26 3:30 PM, Robert Obkircher wrote:
> 
> On 28.08.26 11:18, Christian Ebner wrote:
>> One tiny nit inline and one high level comment: We currently do not
>> document the 5 second caching behavior for manual config file edits,
>> not for the user and not for the acl introduced here. We do have a
>> warning with respect to the more critical 60 seconds for
>> token.shadow caching [0] but maybe we could add a note to the end of
>> [1,2] for completeness as well?
> 
> Do we support manual changes at all? If so, we would also have to
> document that changes must be atomic renames instead of in-place
> updates, and that we recognize them based on mtime.

Good point, makes me question if the currently documented behavior for 
token.shadow stands and does not falsely imply that this is possible 
without the risk of inconsistencies. Might be worth to mention this for 
that warning and in general, but out of scope for this patch.

> 
> The timeout is also not even guaranteed to be 5 seconds, because it is
> based on system time instead of a monotonic clock. I assume this is
> because Instant doesn't work on wasm, but it woudn't be that hard to
> conditionally re-export it in proxmox-sys and replace it with a
> performance.now() wrapper on wasm targets.
> 
> (Imo the generation and timeout checks also belong in the individual
> cached_config methods instead of CachedUserInfo::new, but I'll leave
> it as-is for now.)