all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Robert Obkircher <r.obkircher@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{,-backup} 0/3] add flag to opt-in using node proxy config for s3 connections
Date: Tue, 21 Jul 2026 07:45:16 +0200	[thread overview]
Message-ID: <8b1bba8f-b705-472f-96c2-9d2b42c5eee0@proxmox.com> (raw)
In-Reply-To: <20260511151924.901315-1-c.ebner@proxmox.com>


nit: commit message 2/3 has a typo "explicitley"

I tested that backups stopped working whenever the checkbox was
enabled while a bogus http proxy was configured.

I also verified that they succeeded when it pointed to tinyproxy on
localhost:8888.


Reviewed-by: Robert Obkircher <r.obkircher@proxmox.com>
Tested-by: Robert Obkircher <r.obkircher@proxmox.com>

On 11.05.26 17:17, Christian Ebner wrote:
> Currently, if set the node proxy config is used unconditionally also
> for S3 client API connections. Since this is however not always the
> intention, allow users to expliciteley opt-in for individual S3
> endpoint configurations.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/183436/
>
>
> proxmox:
>
> Christian Ebner (1):
>   s3-client: add flag to opt-in for using node proxy for connections
>
>  proxmox-s3-client/src/api_types.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
>
> proxmox-backup:
>
> Christian Ebner (2):
>   api: config: allow editing the use-node-config flag for s3 endpoints
>   ui: add opt-in flag for using the node proxy config for s3 connections
>
>  pbs-datastore/src/datastore.rs | 14 ++++++++++++--
>  src/api2/admin/s3.rs           |  8 +++++++-
>  src/api2/config/s3.rs          | 16 +++++++++++++++-
>  www/window/S3ClientEdit.js     | 13 +++++++++++++
>  4 files changed, 47 insertions(+), 4 deletions(-)
>
>
> Summary over all repositories:
>   5 files changed, 55 insertions(+), 4 deletions(-)
>




      parent reply	other threads:[~2026-07-21  5:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 15:19 [PATCH proxmox{,-backup} 0/3] add flag to opt-in using node proxy config for s3 connections Christian Ebner
2026-05-11 15:19 ` [PATCH proxmox 1/3] s3-client: add flag to opt-in for using node proxy for connections Christian Ebner
2026-05-11 15:19 ` [PATCH proxmox-backup 2/3] api: config: allow editing the use-node-config flag for s3 endpoints Christian Ebner
2026-05-11 15:19 ` [PATCH proxmox-backup 3/3] ui: add opt-in flag for using the node proxy config for s3 connections Christian Ebner
2026-07-20 13:08 ` [PATCH proxmox{,-backup} 0/3] add flag to opt-in using " Christian Ebner
2026-07-21  8:20   ` Shan Shaji
2026-07-21  5:45 ` Robert Obkircher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b1bba8f-b705-472f-96c2-9d2b42c5eee0@proxmox.com \
    --to=r.obkircher@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal