From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1EAA61FF0B2 for ; Thu, 20 Aug 2026 14:08:01 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4351C2159E; Thu, 20 Aug 2026 14:07:58 +0200 (CEST) Message-ID: <8a1e0166-f721-4832-a4ec-b71663c60b35@proxmox.com> Date: Thu, 20 Aug 2026 14:07:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v3 pve-qemu qemu-server 0/6] bypass host page cache for restore on zvol To: Christian Ebner , Lukas Sichert References: <20260820090528.117853-1-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787227647920 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.985 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KB567SIFMW7VEIMVAGZT6TW25K5CHGBP X-Message-ID-Hash: KB567SIFMW7VEIMVAGZT6TW25K5CHGBP X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/08/2026 11:56, Lukas Sichert wrote: > On 2026-08-20 11:05, Christian Ebner wrote: > >> This patch series skips writing to the host page cache for restores >> to zvols, with the intention to avoid potential I/O delay issues for >> other ZFS-backed VMs during page writeback on certain setups, as >> reported in enterprise support and reproduced internally. >> >> This patch series adds an optional no-cache parameter for pbs-restore >> command invocation, setting the BDRV_O_NOCACHE flag for the block >> device being restored to and sets `cache=none` for vma restores. > > When I test patched debs on my testmachines I normally bump the version > with a local suffigx. package_name_1.2.3 is deployed as > package_name_1.2.3+local1. When starting a restore with this and v2, I got > the error 'TASK ERROR: internal error: cannot check version of invalid > string 'unknown' at /usr/share/perl5/PVE/QemuServer/Helpers.pm line 104.' > > Christian proposed the following diff off-list, which worked for me. > > diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm > index 5065a457..1ed48a3b 100644 > --- a/src/PVE/QemuServer/Helpers.pm > +++ b/src/PVE/QemuServer/Helpers.pm > @@ -68,7 +68,7 @@ sub kvm_user_version { > $kvm_mtime->{$binary} = $st->mtime; > > my $binary_version_re = qr/(\d+\.\d+(\.\d+)?)(\.\d+)?/; > - my $package_version_re = qr/\(pve-qemu-kvm_(\d+\.\d+(\.\d+)?-\d+)\)/; > + my $package_version_re = qr/\(pve-qemu-kvm_(\d+\.\d+(\.\d+)?-\d+)(\+[a-zA-Z0-9]+)?\)/; > > my $code = sub { > my $line = shift; > > I wouldn't consider this a blocker, but it would be a nice to have in a > potential next version. meh, that's far from great - re-implementing all off debians package version seems also futile and hard to maintain; so either we use "dpkg --compare-versions ..." directly via run_command or just bump the versioned dependency in d/control here - even though the latter makes downgrading slightly more work, it is IMO still more preferable for this here, and it would allow us to drop like three patches FWICT.