Re: [PATCH proxmox-ve-rs v2 07/25] ve-config: sdn: fabrics: add wireguard to the fabric config

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 5/4/26 5:58 PM, Hannes Laimer wrote:
> On 2026-04-02 10:14, Stefan Hanreich wrote:
>> Use the newly created WireGuard section types to add the WireGuard
>> variants to the existing fabrics section config enum. By adding the
>> new WireGuard variants, they are automatically exposed via the API
>> methods defined in proxmox-perl-rs and are available for the existing
>> CRUD endpoints in pve-network.
>>
>> Originally-by: Christoph Heiss <c.heiss@proxmox.com>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
> 
> [..]
> 
>> @@ -36,6 +37,18 @@ api_string_type! {
>>      pub struct NodeId(String);
>>  }
>>  
>> +impl std::str::FromStr for NodeId {
>> +    type Err = anyhow::Error;
>> +
>> +    fn from_str(value: &str) -> Result<Self, Self::Err> {
>> +        Self::API_SCHEMA
>> +            .unwrap_string_schema()
>> +            .check_constraints(value)?;
>> +
>> +        Ok(unsafe { Self::from_string_unchecked(value.to_string()) })
>> +    }
>> +}
> 
> proxmox-schema already emits a `impl FromStr` for this
> 
> generally there are some merge conflicts if applied on top of the latest
> route-maps/prefix-list series[1], nothing dramatic, just wanted to note
> it
> 
> didn't get much further than build this on top of [1] today, will look
> at the code more closely and do some testing tomorrow
> 
> 

Conincidentally just sent a new version [1] that should address this,
among other thing.

[1]
https://lore.proxmox.com/pve-devel/20260504161115.408970-1-s.hanreich@proxmox.com/T/#t