From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id F0D3BBB5D0
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:08:54 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id C9BCB1F88B
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:08:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:08:23 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8D7BC40797
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:08:23 +0100 (CET)
Message-ID: <882a1c6e-46cc-4dbb-8ad0-c52c9e5f8b30@proxmox.com>
Date: Mon, 25 Mar 2024 09:08:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexander Zeidler <a.zeidler@proxmox.com>
References: <20240322135933.164404-1-a.zeidler@proxmox.com>
 <20240322135933.164404-2-a.zeidler@proxmox.com>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20240322135933.164404-2-a.zeidler@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.059 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [report.pm]
Subject: Re: [pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug
 related network/load/backup/etc issues
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2024 08:08:55 -0000

On 22/03/2024 14:59, Alexander Zeidler wrote:
> Suggested-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  PVE/Report.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index d4191769..6014f13e 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -35,6 +35,7 @@ my $init_report_cmds = sub {
>  		'pveversion --verbose',
>  		'cat /etc/hosts',
>  		'pvesubscription get',
> +		'cat /etc/pve/jobs.cfg',

This does not really fits the general section, and makes it harder to
see the core subscription and repository state. I'd either add it to the
cluster one, as cluster-wide jobs config, or to a new "Jobs" section,
with a slight preference to the latter. 

>  		'cat /etc/apt/sources.list',
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },