From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 42B5F1FF165 for ; Thu, 6 Nov 2025 09:14:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EE94F9C1; Thu, 6 Nov 2025 09:14:56 +0100 (CET) Message-ID: <87879844-d35e-4acc-8ea6-7d8f877d6df9@proxmox.com> Date: Thu, 6 Nov 2025 09:14:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251105155129.517430-1-n.frey@proxmox.com> <20251105155129.517430-2-n.frey@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251105155129.517430-2-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762416844101 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: jobs: verify: add worker-threads to VerificationJobConfig X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Please mention in a short commit message what this new parameter will be used for, e.g. controls the number of parallel workers to read and verify chunks. On 11/5/25 4:51 PM, Nicolas Frey wrote: > Signed-off-by: Nicolas Frey > --- > pbs-api-types/src/jobs.rs | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs > index 4dbbef2b..d904f797 100644 > --- a/pbs-api-types/src/jobs.rs > +++ b/pbs-api-types/src/jobs.rs > @@ -203,6 +203,13 @@ pub const VERIFICATION_OUTDATED_AFTER_SCHEMA: Schema = > optional: true, > schema: crate::NS_MAX_DEPTH_SCHEMA, > }, > + "worker-threads": { > + type: Integer, > + optional: true, > + minimum: 1, > + maximum: 32, > + default: 1, > + }, Please define this as dedicated schema, so it can be reused for the PBS api as well (as exposed in patch 2). > } > )] > #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)] > @@ -221,6 +228,9 @@ pub struct VerificationJobConfig { > #[serde(skip_serializing_if = "Option::is_none")] > /// Reverify snapshots after X days, never if 0. Ignored if 'ignore_verified' is false. > pub outdated_after: Option, > + /// Set the number of worker threads to use for the job > + #[serde(skip_serializing_if = "Option::is_none")] > + pub worker_threads: Option, > #[serde(skip_serializing_if = "Option::is_none")] > pub comment: Option, > #[serde(skip_serializing_if = "Option::is_none")] _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel