Re: [pve-network 1/2] vnets: introduce get_subnets_with_config

[Daniel Herzig <d.herzig@proxmox.com>]

Thanks for looking into this.

Hannes Laimer <h.laimer@proxmox.com> writes:

> On 2026-08-26 17:43, Daniel Herzig wrote:
>> Add a sub to return the subnets of a vnet with certain subnet configuration given.
>> 
>> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
>> ---
>>  src/PVE/Network/SDN/Vnets.pm | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>> 
>> diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
>> index c327a4b..fdb2dd9 100644
>> --- a/src/PVE/Network/SDN/Vnets.pm
>> +++ b/src/PVE/Network/SDN/Vnets.pm
>> @@ -82,6 +82,19 @@ sub get_subnets {
>>      return $subnets;
>>  }
>>  
>> +sub get_subnets_with_config {
>> +    my ($vnetid, $subnets_cfg) = @_;
>> +
>> +    my $subnets = undef;
>> +    foreach my $subnetid (sort keys %{ $subnets_cfg->{ids} }) {
>> +        my $subnet = PVE::Network::SDN::Subnets::sdn_subnets_config($subnets_cfg, $subnetid);
>> +        next if !$subnet->{vnet} || ($vnetid && $subnet->{vnet} ne $vnetid);
>> +        $subnets->{$subnetid} = $subnet;
>> +    }
>> +
>
> this loop is the same as in `get_subnets`, `get_subnets` could just also
> call this helper, so filtering is only done in one place
>
Thanks for catching this -- I agree that doubling up the procedures here
is not nice. Will send a v2 with calling it from the original `get_subnets`.

>> +    return $subnets;
>> +}
>> +
>>  sub get_subnet_from_vnet_ip {
>>      my ($vnetid, $ip) = @_;
>>