From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 4DDBADE58
 for <pve-devel@lists.proxmox.com>; Wed, 20 Apr 2022 14:12:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 43B35B5AD
 for <pve-devel@lists.proxmox.com>; Wed, 20 Apr 2022 14:12:51 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id C9E2BB5A1
 for <pve-devel@lists.proxmox.com>; Wed, 20 Apr 2022 14:12:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9D36E42556
 for <pve-devel@lists.proxmox.com>; Wed, 20 Apr 2022 14:12:50 +0200 (CEST)
Message-ID: <855ae3c2-f430-a85b-b68e-bee2e48c173b@proxmox.com>
Date: Wed, 20 Apr 2022 14:12:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101
 Thunderbird/100.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Stoiko Ivanov <s.ivanov@proxmox.com>
References: <20220419120231.2161474-1-s.ivanov@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220419120231.2161474-1-s.ivanov@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.040 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: [pve-devel] applied-series: [PATCH installer 0/2] fix 2 bugs
 related to hdsize selection
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 20 Apr 2022 12:12:51 -0000

On 19.04.22 14:02, Stoiko Ivanov wrote:
> noticed that these 2 bugs were still open in bugzilla (and assigned to me).
> 
> The issues are independent of each other - but the fixes touch the same part
> of the code - hence I'm sending them in a common series.
> 
> roughly tested with a VM (scp'ing the updated proxinstall from the
> second debug shell)
> 
> 
> Stoiko Ivanov (2):
>   fix #3188: update hdsize spin-button on disk-selection change
>   fix #3587: make hdsize configurable for btrfs setups
> 
>  proxinstall | 95 ++++++++++++++++++++++++++++++++++++-----------------
>  1 file changed, 65 insertions(+), 30 deletions(-)
> 


applied, thanks! Made some followups on top to avoid the relatively expensive recreation
of the GTK::Adjustment element for each view every time a disk selection change and some
improvements/clean-ups in the pre-existing code too.