From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 542FC7FC5D for ; Mon, 15 Nov 2021 15:00:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 522BEB84F for ; Mon, 15 Nov 2021 15:00:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8739FB83E for ; Mon, 15 Nov 2021 15:00:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 57D0743B8F for ; Mon, 15 Nov 2021 15:00:36 +0100 (CET) Message-ID: <851fc6f6-1717-03f6-47a1-8ddb78dedbbe@proxmox.com> Date: Mon, 15 Nov 2021 15:00:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20211115125846.1891390-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211115125846.1891390-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.256 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.278 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster] parse_datacenter_config: return early if no raw data for parsing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 14:00:38 -0000 On 15.11.21 13:58, Oguz Bektas wrote: > in case datacenter.cfg file is missing (e.g. because node is > standalone), it causes a warning message on 'split'. datacenter.cfg has nothing to do with being a cluster, it applies to stand-alone nodes too ;) > > avoid the warnings by doing an early return to stop processing in case > we got an empty config. > > Signed-off-by: Oguz Bektas > --- > data/PVE/DataCenterConfig.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm > index 2e802d3..8a5892d 100644 > --- a/data/PVE/DataCenterConfig.pm > +++ b/data/PVE/DataCenterConfig.pm > @@ -231,6 +231,8 @@ sub get_datacenter_schema { return $datacenter_schema }; > sub parse_datacenter_config { > my ($filename, $raw) = @_; > > + return {} if !defined($raw); > + We fall back to '' in the parser, only the new split code did not respect that. So, to avoid changing the behavior I went with not returning early: https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=b5e2b244dd794e982811e37bff05c7559b800087 thanks for catching nonetheless! > # description may be comment or key-value pair (or both) > my $comment = ''; > my @lines = split(/\n/, $raw); >