From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id A741A69226
 for <pve-devel@lists.proxmox.com>; Thu, 12 Nov 2020 16:39:34 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 9CDAB1285A
 for <pve-devel@lists.proxmox.com>; Thu, 12 Nov 2020 16:39:34 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 905A11284D
 for <pve-devel@lists.proxmox.com>; Thu, 12 Nov 2020 16:39:33 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 56F3342335
 for <pve-devel@lists.proxmox.com>; Thu, 12 Nov 2020 16:39:33 +0100 (CET)
To: pve-devel@lists.proxmox.com
References: <20200930103243.1200300-1-t.marx@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
Message-ID: <848c3a27-b837-9848-c56a-f4fcef42caf9@proxmox.com>
Date: Thu, 12 Nov 2020 16:39:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20200930103243.1200300-1-t.marx@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.005 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [0.dev, dartlang.org]
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] add changes to support
 local biometric authentication
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 12 Nov 2020 15:39:34 -0000

Maybe a bit more explanation is needed for what this patch actually does.

Once enabled, a fingerprint scan is needed in the following situations:
* open the app
* navigate to the "Sites" panel


for the series:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 9/30/20 12:32 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx <t.marx@proxmox.com>
> ---
>   android/app/src/debug/AndroidManifest.xml     |  2 +
>   android/app/src/main/AndroidManifest.xml      |  1 +
>   .../app/pve_flutter_frontend/MainActivity.kt  |  4 +-
>   pubspec.lock                                  | 52 ++++++++++++-------
>   4 files changed, 38 insertions(+), 21 deletions(-)
> 
> diff --git a/android/app/src/debug/AndroidManifest.xml b/android/app/src/debug/AndroidManifest.xml
> index 617ada1..dd99f60 100644
> --- a/android/app/src/debug/AndroidManifest.xml
> +++ b/android/app/src/debug/AndroidManifest.xml
> @@ -4,4 +4,6 @@
>            to allow setting breakpoints, to provide hot reload, etc.
>       -->
>       <uses-permission android:name="android.permission.INTERNET"/>
> +    <uses-permission android:name="android.permission.USE_FINGERPRINT"/>
> +
>   </manifest>
> diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
> index 529671e..22e4a71 100644
> --- a/android/app/src/main/AndroidManifest.xml
> +++ b/android/app/src/main/AndroidManifest.xml
> @@ -2,6 +2,7 @@
>       package="com.proxmox.app.pve_flutter_frontend">
>   
>       <uses-permission android:name="android.permission.INTERNET"/>
> +    <uses-permission android:name="android.permission.USE_FINGERPRINT"/>
>   
>       <application
>           android:label="Proxmox Virtual Environment"
> diff --git a/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt b/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> index 8b1e324..1458fa0 100644
> --- a/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> +++ b/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> @@ -3,7 +3,7 @@ package com.proxmox.app.pve_flutter_frontend
>   import android.content.ActivityNotFoundException
>   import android.content.Intent
>   import androidx.annotation.NonNull
> -import io.flutter.embedding.android.FlutterActivity
> +import io.flutter.embedding.android.FlutterFragmentActivity
>   import io.flutter.embedding.engine.FlutterEngine
>   import io.flutter.plugin.common.MethodChannel
>   import androidx.core.content.FileProvider
> @@ -16,7 +16,7 @@ import java.io.IOException;
>   import java.io.InputStream;
>   import java.io.OutputStream;
>   
> -class MainActivity: FlutterActivity() {
> +class MainActivity: FlutterFragmentActivity() {
>   
>       private val CHANNEL = "com.proxmox.app.pve_flutter_frontend/filesharing"
>   
> diff --git a/pubspec.lock b/pubspec.lock
> index 831fd91..94886b3 100644
> --- a/pubspec.lock
> +++ b/pubspec.lock
> @@ -28,14 +28,14 @@ packages:
>         name: async
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "2.5.0-nullsafety"
> +    version: "2.5.0-nullsafety.1"
>     boolean_selector:
>       dependency: transitive
>       description:
>         name: boolean_selector
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "2.1.0-nullsafety"
> +    version: "2.1.0-nullsafety.1"
>     build:
>       dependency: transitive
>       description:
> @@ -105,14 +105,14 @@ packages:
>         name: characters
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.1.0-nullsafety.2"
> +    version: "1.1.0-nullsafety.3"
>     charcode:
>       dependency: transitive
>       description:
>         name: charcode
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.2.0-nullsafety"
> +    version: "1.2.0-nullsafety.1"
>     checked_yaml:
>       dependency: transitive
>       description:
> @@ -133,7 +133,7 @@ packages:
>         name: clock
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.1.0-nullsafety"
> +    version: "1.1.0-nullsafety.1"
>     code_builder:
>       dependency: transitive
>       description:
> @@ -147,7 +147,7 @@ packages:
>         name: collection
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.15.0-nullsafety.2"
> +    version: "1.15.0-nullsafety.3"
>     convert:
>       dependency: transitive
>       description:
> @@ -189,7 +189,7 @@ packages:
>         name: fake_async
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.1.0-nullsafety"
> +    version: "1.2.0-nullsafety.1"
>     ffi:
>       dependency: transitive
>       description:
> @@ -216,6 +216,13 @@ packages:
>       description: flutter
>       source: sdk
>       version: "0.0.0"
> +  flutter_plugin_android_lifecycle:
> +    dependency: transitive
> +    description:
> +      name: flutter_plugin_android_lifecycle
> +      url: "https://pub.dartlang.org"
> +    source: hosted
> +    version: "1.0.11"
>     flutter_test:
>       dependency: "direct dev"
>       description: flutter
> @@ -303,6 +310,13 @@ packages:
>         url: "https://pub.dartlang.org"
>       source: hosted
>       version: "3.1.0"
> +  local_auth:
> +    dependency: transitive
> +    description:
> +      name: local_auth
> +      url: "https://pub.dartlang.org"
> +    source: hosted
> +    version: "0.6.3+2"
>     logging:
>       dependency: transitive
>       description:
> @@ -316,14 +330,14 @@ packages:
>         name: matcher
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "0.12.10-nullsafety"
> +    version: "0.12.10-nullsafety.1"
>     meta:
>       dependency: "direct main"
>       description:
>         name: meta
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.3.0-nullsafety.2"
> +    version: "1.3.0-nullsafety.3"
>     mime:
>       dependency: transitive
>       description:
> @@ -365,7 +379,7 @@ packages:
>         name: path
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.8.0-nullsafety"
> +    version: "1.8.0-nullsafety.1"
>     path_provider:
>       dependency: "direct main"
>       description:
> @@ -573,21 +587,21 @@ packages:
>         name: source_span
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.8.0-nullsafety"
> +    version: "1.8.0-nullsafety.2"
>     stack_trace:
>       dependency: transitive
>       description:
>         name: stack_trace
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.10.0-nullsafety"
> +    version: "1.10.0-nullsafety.1"
>     stream_channel:
>       dependency: transitive
>       description:
>         name: stream_channel
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "2.1.0-nullsafety"
> +    version: "2.1.0-nullsafety.1"
>     stream_transform:
>       dependency: transitive
>       description:
> @@ -601,21 +615,21 @@ packages:
>         name: string_scanner
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.1.0-nullsafety"
> +    version: "1.1.0-nullsafety.1"
>     term_glyph:
>       dependency: transitive
>       description:
>         name: term_glyph
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.2.0-nullsafety"
> +    version: "1.2.0-nullsafety.1"
>     test_api:
>       dependency: transitive
>       description:
>         name: test_api
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "0.2.19-nullsafety"
> +    version: "0.2.19-nullsafety.2"
>     timing:
>       dependency: transitive
>       description:
> @@ -629,7 +643,7 @@ packages:
>         name: typed_data
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "1.3.0-nullsafety.2"
> +    version: "1.3.0-nullsafety.3"
>     url_launcher:
>       dependency: "direct main"
>       description:
> @@ -678,7 +692,7 @@ packages:
>         name: vector_math
>         url: "https://pub.dartlang.org"
>       source: hosted
> -    version: "2.1.0-nullsafety.2"
> +    version: "2.1.0-nullsafety.3"
>     watcher:
>       dependency: transitive
>       description:
> @@ -715,5 +729,5 @@ packages:
>       source: hosted
>       version: "2.2.1"
>   sdks:
> -  dart: ">=2.10.0-0.0.dev <2.10.0"
> +  dart: ">=2.10.0-110 <=2.11.0-176.0.dev"
>     flutter: ">=1.12.13+hotfix.5 <2.0.0"
>