From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE3641FF136 for ; Mon, 23 Feb 2026 10:48:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F09D462F0; Mon, 23 Feb 2026 10:49:00 +0100 (CET) Message-ID: <848b6167-079f-43a4-9c4d-891dd14a8cc1@proxmox.com> Date: Mon, 23 Feb 2026 10:48:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds To: Benjamin McGuire , Dominik Csapak References: <20260210111612.2017883-1-d.csapak@proxmox.com> <7ee8d206-36fd-4ade-893b-c7c2222a8883@proxmox.com> <1770985110.nme4v4xomn.astroid@yuna.none> <9d501c98-a85c-44d4-af0e-0301b203d691@proxmox.com> <1771231158.rte62d97r5.astroid@yuna.none> <38236a30-a249-4ebe-bf89-788d67f36bd1@proxmox.com> <7bbce03b-d8d6-4459-876c-2a71257959a4@proxmox.com> <8099db49-d35a-4ab1-9e33-c82689aee016@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771840091485 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NKOH6UDPXXJDCSHON63BYKTVEXFFO3LD X-Message-ID-Hash: NKOH6UDPXXJDCSHON63BYKTVEXFFO3LD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 21.02.26 um 4:12 AM schrieb Benjamin McGuire: > I’ve come up with a different patch where the wait happens in the child process that runs the qm cleanup (With help from Cursor). If I wanted to scrutinize LLM output, I could ask an LLM myself. You don't need to play middle man. >>From a quick look, the generated patch completely ignores the part of the issue with cleanup being attempted twice. And no, this is not an invitation to ask the LLM again for such a patch. > This way, we avoid any Perl-side polling or sleeping while holding the > VM config lock, which was the way we did it in the v2 patch. Holding the config lock is desired in this case. It's better if no other operation should take the lock and interfere before cleanup is done. Please do not post such things to the mailing list. It just side-tracks the discussion, is a legal gray zone and a wasteful use of resources. Best Regards, Fiona