From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 635BF1FF16B for ; Fri, 10 Oct 2025 14:43:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0AA041456E; Fri, 10 Oct 2025 14:43:58 +0200 (CEST) Message-ID: <83bc679c-8c56-476c-8910-6600e507056e@proxmox.com> Date: Fri, 10 Oct 2025 14:43:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dietmar Maurer , Yew framework devel list at Proxmox References: <20251009133120.425255-1-h.laimer@proxmox.com> <20251009133120.425255-3-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760100202745 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [PATCH proxmox-yew-comp v3 1/2] schema_validation: use Schema to populate field properties of number, check- and combobox X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" On 10/10/25 10:32, Dietmar Maurer wrote: > partially applied. > > - setting placeholder is OK > > - setting tips from description is problematic, because those > description are basically for developers and have no translations, so I > think its not worth to do it. > > - setting field default values form schema default is most times not > what you need (depends highly on your input form logic) > > - setting validator for Number makes no sense > (schema.parse_simple_value() does not add any advantage, because values > are already parsed - correct me if I am wrong) > > - auto-generating Combobox is usually not what we want, because we > display translated, annotated items... > hmm, we can still do that though. for combobox items specifically I feel like having it still adds some value. There are places where we don't, and a later .items() does override whatever we took from the schema if we want to set them ourself. We don't for example for firewall logging levels or firewall policies like DROP, REJECT, ACCEPT. Also having the default as a placeholder automatically is, if nothing else, convenient. tbh, I'm not super sure how often we do this, so may not be warranted to have a general thing if only these two end up using it. > - Dietmar > > _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel