From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EBEFD61D94; Wed, 19 Aug 2020 15:42:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9AB125595; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6354525588; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F9174469B; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200813115027.11333-1-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <81d2255e-ac6b-f02a-958c-6e9e3a4a8ce1@proxmox.com> Date: Wed, 19 Aug 2020 15:42:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200813115027.11333-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu] PVE: add zero block handling to PBS dump callback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 19 Aug 2020 13:42:40 -0000 On 13.08.20 13:50, Stefan Reiter wrote: > Both the PBS and VMA dump callbacks assume that a NULL pointer can be > passed as *pbuf, but that never happens, as backup-dump.c calls this > function with contents of an iovec. > > So first, remove that assumption and add an 'assert' to verify. > > Secondly, while the vma-writer already does the buffer_is_zero check > internally, for PBS we relied on that non-existant behaviour for zero > chunks, so do the buffer_is_zero check manually and pass NULL to the > rust lib in case it is true. > > Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> > --- > > This increases backup speed to PBS for VMs with free space quite dramatically. > > pve-backup.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EBEFD61D94; Wed, 19 Aug 2020 15:42:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9AB125595; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6354525588; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F9174469B; Wed, 19 Aug 2020 15:42:09 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200813115027.11333-1-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <81d2255e-ac6b-f02a-958c-6e9e3a4a8ce1@proxmox.com> Date: Wed, 19 Aug 2020 15:42:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200813115027.11333-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [pve-devel] [PATCH qemu] PVE: add zero block handling to PBS dump callback X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 19 Aug 2020 13:42:40 -0000 On 13.08.20 13:50, Stefan Reiter wrote: > Both the PBS and VMA dump callbacks assume that a NULL pointer can be > passed as *pbuf, but that never happens, as backup-dump.c calls this > function with contents of an iovec. > > So first, remove that assumption and add an 'assert' to verify. > > Secondly, while the vma-writer already does the buffer_is_zero check > internally, for PBS we relied on that non-existant behaviour for zero > chunks, so do the buffer_is_zero check manually and pass NULL to the > rust lib in case it is true. > > Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> > --- > > This increases backup speed to PBS for VMs with free space quite dramatically. > > pve-backup.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > applied, thanks!