From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5F2339910 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 15:36:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D3D11DC33 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 15:36:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E55B31DC2A for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 15:36:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7AA042B5E for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 15:36:45 +0200 (CEST) Message-ID: <81c8f625-d6d9-4389-2605-0ae940aa817f@proxmox.com> Date: Tue, 26 Apr 2022 15:36:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20220309082128.760917-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220309082128.760917-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.221 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dirplugin.pm, plugin.pm] Subject: [pve-devel] applied: [PATCH storage] Plugins: en/decode notes as UTF-8 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 26 Apr 2022 13:36:46 -0000 On 09.03.22 09:21, Dominik Csapak wrote: > When writing into the file, explicitly utf8 encode it, and then try to > utf8 decode it on read. >=20 > If the notes are not valid utf8, we assume it was an iso-8859 comment > and return is at is was. >=20 > Technically this is a breaking change, since there are iso-8859 comment= s > that would sucessfully decode as utf8, for example: > the byte sequence "C2 A9" would be "=C3=82=C2=A3" in iso, but would dec= ode to "=C2=A3". >=20 > From what i can tell though, this is rather unlikely to happen for > "real world" notes, because the first byte would be in the range of > C0-F7 (which are mostly language dependent characters like "=C3=82") > and the following bytes would have to be in the range of > 80-BF, which are only special characters like "=C2=A3" (or undefined) >=20 > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > PVE/Storage/DirPlugin.pm | 9 +++++++-- > PVE/Storage/Plugin.pm | 3 ++- > 2 files changed, 9 insertions(+), 3 deletions(-) >=20 > applied, with commit message typos (there where at least one other) fixed= , thanks!