From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5A661AA36 for <pbs-devel@lists.proxmox.com>; Wed, 27 Apr 2022 19:40:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E44629B0E for <pbs-devel@lists.proxmox.com>; Wed, 27 Apr 2022 19:40:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B0FDF29B03 for <pbs-devel@lists.proxmox.com>; Wed, 27 Apr 2022 19:40:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8812C42EB5 for <pbs-devel@lists.proxmox.com>; Wed, 27 Apr 2022 19:40:24 +0200 (CEST) Message-ID: <80ddb212-deb1-8492-d9ab-d94461e39b8c@proxmox.com> Date: Wed, 27 Apr 2022 19:40:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> References: <20220426062335.6215-1-h.laimer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220426062335.6215-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 0/6] improve UI for maintenance mode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 27 Apr 2022 17:40:25 -0000 On 26.04.22 08:23, Hannes Laimer wrote: > Adds mask for datastore summary when in maintenance mode and dynamically > updates icon and tooltip in datastore list. The 4th patch is optional, > and could be squashed with the 3rd path if applied, it would make the > icon update more responsive and not that delayed, but not sure if that is > even a problem. > > v2, thanks @Fabian + @Thomas: > - fix backwards compat. for DataStoreListItem > - add parse function for maintenance mode to utils > - show tooltip (<type>[: <message>]) in datastore list > - use icon itself instead of .svg for wrench > > Hannes Laimer (6): > ui: add summary mask when in maintenance mode > api2: DataStoreListItem add maintenance info > ui: update icon in datastore list when in maintenance mode > ui: update datastore list more often > ui: utils: add function for parsing maintenance mode > ui: add tooltip to datastore in maintenance mode > > pbs-api-types/src/datastore.rs | 8 ++++++ > src/api2/admin/datastore.rs | 1 + > www/NavigationTree.js | 45 ++++++++++++++++++++++++++------ > www/Utils.js | 17 +++++++++--- > www/css/ext6-pbs.css | 32 +++++++++++++++++++++++ > www/datastore/Summary.js | 21 ++++++++++++++- > www/window/MaintenanceOptions.js | 8 ++---- > 7 files changed, 113 insertions(+), 19 deletions(-) > applied, looks quite nice now, thanks! two nits/possible improvements: * if I put the datastore in offline mode, then go to the content tab I get the view masked with the "datastore in maintenance mode" error, so far so good. Now, if I disable maintenance mode again and switch back to the content tab (wihtout navigating anywhere else) I still see that view masked with the same error, even if I waited for 10s or so. It helps to either navigate to some other navigation element (e.g., another datastore or "Administration") and then back again so no "biggie" but maybe we could see if the mask can be cleared more actively. * w.r.t. the increased frequency we poll now the datastore list for the navigation status/icon: maybe we could keep the previous 15s period and just do one extra reload on setting the maintenance mode, after all it's quite likely that not many admins are online at the same time and the most important one to get immediate feedback is for the one who set the maintenance mode in the first place. as said, just nits but they stuck somewhat out to me.