all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH ha-manager v2 02/16] tree-wide: use the term vmid instead of name when referring to VMs/CTs
Date: Thu, 12 Nov 2026 23:33:24 +0100	[thread overview]
Message-ID: <7fad08fb-62eb-4e5a-b73e-800ec7e46c04@proxmox.com> (raw)
In-Reply-To: <20261112163113.294302-5-d.kral@proxmox.com>

Am 12.11.26 um 17:33 schrieb Daniel Kral:
> The variable name $name is a bit generic when referring to the unique
> identifier for VMs/CTs, so actually name it after its identifier VMID.

FWIW, this variable naming came from the original plan of adding
more resources types besides VMs and CTs, which was then scrapped
(I briefly tried with a floating IP ages ago, but it wasn't really
worth it especially as setting up e.g. HAProxy gives one a bit
nicer properties here.

So this renaming might be OK to do, just wanted to give some
history context for why these variable names were chosen.

btw. this is also the main reason for why the type is in the sid.
As just for guest IDs we know that they are unique and can be always
mapped to their underlying type just by the plain integer VMID anyway,
but the preparation for generic resource types made this sensible.

($sid, $type, $name) -> ($resource, $type, $id) (or $resource_type,
$resource_id) would be technically probably the more fitting and/or
consequent rename, but again not sure if worth the churn. Also you
here still use "name" in e.g. "verify_name" method name.

btw. I can get where you come from, but such renaming patches might
be actually suited better at the back of a series to allow easily
omitting them, as they are a great bikeshedding target (proof: see
this reply ;-))

Given the next parse_vmid_or_sid patch and also the goal of this
series being performance improvement, which often gets most out
of leveraging the specific use case rather over the intended
potential future use case that did not materialize in over a decade
of this software stack (time really flies) I can be fine with
more actively going away from that premise (still not /that/ happy,
it still feels like we leave out some potential unused then - otoh,
can all be reworked again in the future if really needed).




  reply	other threads:[~2026-11-12 22:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 16:30 [PATCH-SERIES ha-manager v2 00/16] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 01/16] resources: remove commented ipaddr resource type Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 02/16] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-12 22:33   ` Thomas Lamprecht [this message]
2026-11-13 15:04     ` Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 03/16] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 04/16] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 05/16] make parse_sid always return an array Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 06/16] config: use early returns in parse_sid Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 07/16] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 08/16] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 09/16] lrm: rename update_lrm_status to flush_lrm_status Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 10/16] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 11/16] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 12/16] lrm: update the service status once per work iteration Daniel Kral
2026-11-16 10:32   ` Michael Köppl
2026-11-16 12:40     ` Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 13/16] lrm: read service config " Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 14/16] lrm: compute valid service uids hash set " Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 15/16] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 16/16] lrm: prune stale LRM results once per work iteration Daniel Kral
2026-11-17 18:58 ` [PATCH-SERIES ha-manager v2 00/16] some sid parsing and LRM speedup improvements Michael Köppl
2026-11-18 14:41 ` superseded: " Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fad08fb-62eb-4e5a-b73e-800ec7e46c04@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal