Re: [PATCH container v9 05/10] allow pending mount point changes if storage is gone

[Fiona Ebner <f.ebner@proxmox.com>]

Am 01.07.26 um 2:15 PM schrieb Michael Köppl:
> On Tue Jun 30, 2026 at 3:41 PM CEST, Fiona Ebner wrote:
>> I'm thinking about something like
>>
>> with_checked_volid($opt, $conf->{opt}, sub {
>>     my ($volid) = @_;
>>     PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $volid)
>>         if !$class->is_volume_in_use($conf, $volid, 1, 1);
>> });
>>
>> where the helper does the parsing of the volume and volid, logs the
>> warning and returns if the storage does not exist and calls the
>> passed-in sub if it does exist.
> 
> Sounds good, I'll add a helper. Thanks for the suggestion. Though I'd go
> with something like:
> 
> ```
> sub with_checked_volid {
>     my ($storecfg, $volid, $callback) = @_;
> 
>     my ($storeid) = PVE::Storage::parse_volume_id($volid);
>     if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {
>         callback->();
>     } else {
>         PVE::RESTEnvironment::log_warn(
>             "storage '$storeid' no longer exists, volume '$volid' will be removed");
>     }
> }
> ```
> 
> I'd keep the parsing of the volume outside the helper. The call sites
> don't use the result of parse_volume uniformly. It seems easier to me
> using the same helper across all call sites by passing in an already
> resolved volid as the common denominator. What do you think?

Sound good :)