all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] auto-installer: fix answer-request charset
@ 2024-04-26  8:12 Fabian Grünbichler
  2024-07-05  8:02 ` Christoph Heiss
  2024-07-05  8:19 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Fabian Grünbichler @ 2024-04-26  8:12 UTC (permalink / raw)
  To: pve-devel

'utf-' is a typo, and can trip up some servers that do strict
checking/matching.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/

 proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs
index 1c5e9ea..21bc6a2 100644
--- a/proxmox-fetch-answer/src/fetch_plugins/http.rs
+++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs
@@ -211,7 +211,7 @@ mod http_post {
 
             answer = agent
                 .post(&url)
-                .set("Content-type", "application/json; charset=utf-")
+                .set("Content-type", "application/json; charset=utf-8")
                 .send_string(&payload)?
                 .into_string()?;
         } else {
@@ -231,7 +231,7 @@ mod http_post {
                 .build();
             answer = agent
                 .post(&url)
-                .set("Content-type", "application/json; charset=utf-")
+                .set("Content-type", "application/json; charset=utf-8")
                 .timeout(std::time::Duration::from_secs(60))
                 .send_string(&payload)?
                 .into_string()?;
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH installer] auto-installer: fix answer-request charset
  2024-04-26  8:12 [pve-devel] [PATCH installer] auto-installer: fix answer-request charset Fabian Grünbichler
@ 2024-07-05  8:02 ` Christoph Heiss
  2024-07-05  8:19 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Heiss @ 2024-07-05  8:02 UTC (permalink / raw)
  To: Fabian Grünbichler; +Cc: Proxmox VE development discussion

Important fix, apparently slipped through in April.
"Re-discovered" it yesterday by coincidence while talking to Aaron.

On Fri, Apr 26, 2024 at 10:12:55AM GMT, Fabian Grünbichler wrote:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

> ---
>
> Notes:
>     see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
>
>  proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> index 1c5e9ea..21bc6a2 100644
> --- a/proxmox-fetch-answer/src/fetch_plugins/http.rs
> +++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> @@ -211,7 +211,7 @@ mod http_post {
>
>              answer = agent
>                  .post(&url)
> -                .set("Content-type", "application/json; charset=utf-")
> +                .set("Content-type", "application/json; charset=utf-8")
>                  .send_string(&payload)?
>                  .into_string()?;
>          } else {
> @@ -231,7 +231,7 @@ mod http_post {
>                  .build();
>              answer = agent
>                  .post(&url)
> -                .set("Content-type", "application/json; charset=utf-")
> +                .set("Content-type", "application/json; charset=utf-8")
>                  .timeout(std::time::Duration::from_secs(60))
>                  .send_string(&payload)?
>                  .into_string()?;
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH installer] auto-installer: fix answer-request charset
  2024-04-26  8:12 [pve-devel] [PATCH installer] auto-installer: fix answer-request charset Fabian Grünbichler
  2024-07-05  8:02 ` Christoph Heiss
@ 2024-07-05  8:19 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-07-05  8:19 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Grünbichler

Am 26/04/2024 um 10:12 schrieb Fabian Grünbichler:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
> 
>  proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, with Christoph's R-b, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-05  8:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26  8:12 [pve-devel] [PATCH installer] auto-installer: fix answer-request charset Fabian Grünbichler
2024-07-05  8:02 ` Christoph Heiss
2024-07-05  8:19 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal