Re: [PATCH kernel-helper] kernel hooks: flag pending reboot after installing a new kernel

[Jonas Theisen <j.theisen@proxmox.com>]

On 10/14/26 11:52, Thomas Lamprecht wrote:
> Am 14.10.26 um 11:37 schrieb Jonas Theisen:
>> <snip>
>>
>> Should i also include these refs in the commit message?
> Yes, please, at least in some basic prose form describing how
> this is checked/used with [X] reference to the repo/file/docs/...
>
Ack!
>>>> +echo "*** System restart required ***" > /run/reboot-required
>>> That's always truncating any existing reboot-required file though?
>>> Or doesn't that matter because it will be either not there or contain
>>> exactly this string? In any case, needs either fixing or mentioning
>>> that its fine in the commit message and maybe even a short
>> According to my understanding of this files usage it is just checked
>> for existence and printed in the motd. The content seems to be irrelevant.
> Ack, then it's at least not that problematic, but potentially still not
> nice to blindly override it? Did you check how others - e.g. debian or
> ubuntu handles this for kernel updates? As just adding a lot of
> complexity with not much gain is not really worth it either, but maybe
> others came up with a sensible solution here already.

Ubuntu's update-notifier uses the same truncation:

data/notify-reboot-required:

26 echo "*** $(eval_gettext "System restart required") ***" > 
/var/run/reboot-required
27 echo "$DPKG_MAINTSCRIPT_PACKAGE" >> /var/run/reboot-required.pkgs

Debian does not have an equivalent natively but the package
reboot-notifier works the same way and also truncates the 
reboot-required file.