From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E2A56077C for <pve-devel@lists.proxmox.com>; Thu, 26 Nov 2020 11:00:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E647DB92 for <pve-devel@lists.proxmox.com>; Thu, 26 Nov 2020 10:59:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C5404DB88 for <pve-devel@lists.proxmox.com>; Thu, 26 Nov 2020 10:59:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8419D45C67 for <pve-devel@lists.proxmox.com>; Thu, 26 Nov 2020 10:59:50 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20201126081953.25954-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <7bc5b302-901b-b30b-3806-3b9558f82fcc@proxmox.com> Date: Thu, 26 Nov 2020 10:59:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201126081953.25954-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sencha.com] Subject: [pve-devel] applied: [PATCH manager] ui: fix usage of findRecord X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 26 Nov 2020 10:00:21 -0000 On 26.11.20 09:19, Dominik Csapak wrote: > findRecord does not match exactly, but only at the beginning and > case insensitive, by default. Change all calls to be case sensitive > and an exactmatch (we never want the default behaviour afaics). >=20 > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > www/manager6/dc/Backup.js | 4 ++-- > www/manager6/dc/SecurityGroups.js | 2 +- > www/manager6/form/ACMEAPISelector.js | 2 +- > www/manager6/form/NodeSelector.js | 2 +- > www/manager6/form/VMCPUFlagSelector.js | 2 +- > www/manager6/form/ViewSelector.js | 2 +- > www/manager6/grid/BackupView.js | 6 ++++-- > www/manager6/grid/FirewallAliases.js | 2 +- > www/manager6/panel/IPSet.js | 2 +- > www/manager6/window/Backup.js | 2 +- > 10 files changed, 14 insertions(+), 12 deletions(-) >=20 > applied, thanks! as talked off-list, I would find it more ergonomic to ad= d a "findExactRecord" which combines the advantages of the existing findExact= and findRecord methods. https://docs.sencha.com/extjs/6.0.1/classic/src/AbstractStore.js.html#lin= e341