From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A6F405BB4C for ; Wed, 8 Jul 2020 09:16:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EF232D6D0 for ; Wed, 8 Jul 2020 09:16:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 015042D6B4 for ; Wed, 8 Jul 2020 09:16:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 32BC2422DD for ; Wed, 8 Jul 2020 09:11:14 +0200 (CEST) To: PVE development discussion , Aaron Lauterer , pve-devel@pve.proxmox.com References: <20200707094902.24712-1-a.lauterer@proxmox.com> <20200707094902.24712-2-a.lauterer@proxmox.com> From: Thomas Lamprecht Message-ID: <7bc54d06-3004-3b8c-e7c8-1f12f9ac3746@proxmox.com> Date: Wed, 8 Jul 2020 09:11:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200707094902.24712-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm] Subject: Re: [pve-devel] [PATCH v4 manager 1/5] api: backup: add endpoint to list included guests and volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 07:16:25 -0000 On 07.07.20 11:48, Aaron Lauterer wrote: > This patch adds a new API endpoint that returns a list of included > guests, their volumes and whether they are included in a backup. > > The output is formatted to be used with the extJS tree panel. > > Signed-off-by: Aaron Lauterer > --- > The return types are `qemu`, `lxc` and `unknown`. The latter is there on > purpose because it is possible that a deleted but not purged VM is still > configured on a backup job. While the backup job itself will fail, I > think it is good to show it in the job detail view so users can react to > it. > > v3 -> v4: > * remove the "not all permissions" field as we never show such > notifications anywhere else. This makes the returned data simpler > * define objects to be pushed in the return data directly in the push > operation and not way ahead in the code. > > v2 -> v3 (hopefully I got them all): > * incorporate feedback from thomas > * changed double negative for permissions `not_all_permissions` to > `permissions_for_all` > * adapted to latest changes to return values from `get_included_guests` > * define $guest only once > * return VMID as int > * renamed some vars to be more descriptive > > v1 -> v2: > * simplified the code > * refactored according to feedback > > > PVE/API2/Backup.pm | 174 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 174 insertions(+) > > diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm > index 86377c0a..6fbe2106 100644 > --- a/PVE/API2/Backup.pm A slipped into here, git am -3 handles it like a champ though.. Further, when applying this series I get: > implement me - abstract method (500) In the detail window, am I still missing some other part or package bump?