From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 3EE0769EC0
 for <pbs-devel@lists.proxmox.com>; Wed,  3 Mar 2021 14:05:59 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 35B323760C
 for <pbs-devel@lists.proxmox.com>; Wed,  3 Mar 2021 14:05:59 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 747E0375FE
 for <pbs-devel@lists.proxmox.com>; Wed,  3 Mar 2021 14:05:58 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 40D5945859
 for <pbs-devel@lists.proxmox.com>; Wed,  3 Mar 2021 14:05:58 +0100 (CET)
Message-ID: <7bb751c7-323c-ce76-f2a4-0c9980de28ad@proxmox.com>
Date: Wed, 3 Mar 2021 14:05:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101
 Thunderbird/87.0
Content-Language: en-US
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20210225090122.1094-1-d.csapak@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210225090122.1094-1-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.054 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [tfa.rs]
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 0/4] improving
 webauthn handling
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 13:05:59 -0000

On 25.02.21 10:01, Dominik Csapak wrote:
> it seems my gui patch for setting the userverification was a bit
> hasty, since the rust crate has some options for that
> 
> this series reverts the gui part, and sets the backend
> to 'discourage' userVerification, since 'Preferred' is not more secure
> and makes logging in harder (on some devices)
> 
> in the future (when [0] is solved), we could expose a server
> setting (either per instance or per user) that sets either always
> 'Discouraged' or 'Required'
> 
> changes from v1:
> * show webauthn errors on login
> * explicitly handle register errors, and try to give a meaningful message
>   for errors that indicate a duplicate authenticator
> 
> 0: https://github.com/kanidm/webauthn-rs/pull/49
> 
> Dominik Csapak (4):
>   config/tfa: set UserVerificationPolicy to Discouraged
>   Revert "ui: window/Settings / WebAuthn: add browser setting for
>     userVerificationo"
>   config/tfa: webauthn: disallow registering a token twice
>   ui: LoginView: show webauthn errors in window
> 
>  src/config/tfa.rs         | 19 ++++++++++++++++---
>  www/LoginView.js          | 19 ++++++++++++++-----
>  www/window/AddWebauthn.js | 34 ++++++++++++++++++++++++++--------
>  www/window/Settings.js    | 30 +-----------------------------
>  4 files changed, 57 insertions(+), 45 deletions(-)
> 



applied series, with a followup for the exception message as talked off-list, thanks!