From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 50B4B1FF2C7 for ; Wed, 24 Jul 2024 11:58:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D51E18B39; Wed, 24 Jul 2024 11:59:26 +0200 (CEST) Message-ID: <7b89263e-0efa-44fc-b5d4-8acea3684540@proxmox.com> Date: Wed, 24 Jul 2024 11:59:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20240426075836.1634428-1-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240426075836.1634428-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs] passthrough: viommu: remove 'amd_iommu=on' from the docs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 26.04.24 um 09:58 schrieb Dominik Csapak: > this is wrong and does nothing, see previous commit: > 0c54d61 (remove 'amd_iommu=on' from the passthrough docs) > and > https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu > > Signed-off-by: Dominik Csapak > --- > qm-pci-passthrough.adoc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc > index bbd6b85..14f7fa5 100644 > --- a/qm-pci-passthrough.adoc > +++ b/qm-pci-passthrough.adoc > @@ -511,8 +511,7 @@ There are currently two vIOMMU implementations available: Intel and VirtIO. > > Host requirement: > > -* Add `intel_iommu=on` or `amd_iommu=on` depending on your CPU to your kernel > -command line. > +* Add `intel_iommu=on` depending on your CPU to your kernel command line. > IMHO saying "For Intel CPUs, add ..." sounds nicer than "add ... depending on your CPU" together with your change. And we could also mention that it's only required for kernels before 6.8 and nothing for AMD CPUs? > Intel vIOMMU > ^^^^^^^^^^^^ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel