From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 944A11FF16B for ; Fri, 7 Nov 2025 08:47:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D61E8EE3; Fri, 7 Nov 2025 08:47:45 +0100 (CET) Message-ID: <7b58d965-c5cd-499f-bf3f-2a911424d19e@proxmox.com> Date: Fri, 7 Nov 2025 08:47:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Thomas Lamprecht , Nicolas Frey References: <20251106161316.528349-1-n.frey@proxmox.com> <20251106161316.528349-3-n.frey@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762501641990 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/6/25 6:43 PM, Thomas Lamprecht wrote: > Am 06.11.25 um 17:13 schrieb Nicolas Frey: >> controls the number of parallel threads to read/verify chunks. >> > > Any thoughts on having these options (also) in the datastore config's tuning > options? No hard feelings for that, just something I asked myself. Can be fine > to not do now (it's easier to add things later than having to remove them again), > but might still warrant adding some reasoning for choosing the verification > config here in the commit message, at least if there's the need for a v3. Could > be fleeced in on applying otherwise. Yes, setting this also on a datastore level for global defaults make a lot of sense indeed. Would allow to run regular verification's (e.g. immediate verification after backup) with these global defaults and maybe dial up the number of reads/verifies for a monthly full datastore verification job, running at a time where there is not much other CPU and IO load. Although I'm not sure if we should place these in the tuning options, they are a bit crowded already. We could add dedicated `worker-thread-settings` to the datastore config instead? That is, if we commit to having these kind of knobs exposed for other workers (e.g. tape) as well. What's your opinion on that? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel