Re: [PATCH datacenter-manager] ui: auto-installer: correctly validate numeric counters in form

[Dominik Csapak <d.csapak@proxmox.com>]

On 5/26/26 4:18 PM, Lukas Wagner wrote:
> On Tue May 26, 2026 at 4:06 PM CEST, Dominik Csapak wrote:
>> field values are usually strings, so when a user entered any number
>> here, it would display:
>>
>> invalid value: "1"
>>
>> since only numbers were expected here.
>>
>> To fix this, simply parse strings into numbers.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> index d932efe7..b5c59626 100644
>> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> @@ -1040,7 +1040,12 @@ fn kv_list_to_template_counter_map_validate(v: &Vec<(String, Value)>) -> Result<
>>       let mut map = BTreeMap::<String, i32>::new();
>>       for (k, v) in v {
>>           if TEMPLATE_COUNTER_NAME_REGEX.is_match(k) {
>> -            match v.as_i64().and_then(|v| v.try_into().ok()) {
>> +            let value = match v {
>> +                Value::Number(number) => number.as_i64(),
>> +                Value::String(text) => text.parse().ok(),
>> +                _ => None,
>> +            };
>> +            match value.and_then(|v| v.try_into().ok()) {
>>                   Some(v) => {
>>                       map.insert(k.clone(), v);
>>                   }
> 
> I'm still getting a 'invalid value: ""' when adding a new template
> counter, the error goes away once I edit the "Current Value" (e.g delete
> the '0' and type in '0' again).
> 
> Can you reproduce this?


yep, true. i'll see what i can do