From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 601961FF0B2 for ; Fri, 09 Oct 2026 09:00:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 735A6214ED; Fri, 09 Oct 2026 09:00:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791529221; x=1792134021; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bCEJHFi9GpAEWiUFk1yx5nWAPJLU95CrRBHdjL/nEPU=; b=BOsxKyWDz7KcJ9CaiXs/YtUWv4lcl0FNZf/1pDLAbAfoJ5Eq4C6o/EUND9kQmkX6DJ lx4opWh7LO3pEVW8SrZngYFVLjYWaKnIBZUwKZZLFmwBmtJU4gFzn7TCWHneps2op6cA m8/fvkRrBCAvXcNA69qmbnp4aaxpjoNIEG6SXTa2FpwM1G0I5jEN606gKayqxcdmga9Q /B5cIwK0hy+7pptTb6I2ZKQTnesdvh7nHod0JBpO2cVFg6AX0Sas2rh+ZePnullmOfqy z5vA0hl2sfbx3yI0MVzEO9DQHlyZq4ajIWG/cLmIWcHJPNTEV2TXoM3UT9e8t31vXfgf 208Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791529221; x=1792134021; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bCEJHFi9GpAEWiUFk1yx5nWAPJLU95CrRBHdjL/nEPU=; b=f1/mawQyTU6vb+G4KtikHRMtJc0xCR0b/rOWG+pvmGRubh+wUAxojglaFSoHclaRH7 MnagmyvwTonxmlOIy1NTuEbAcR01+kSIzP2S9D8DcvaBMlnCpbxHH69ZH+T9IF0zta0y MDERjvj7NjD8PxqaoYleWTQyFzzyjtSFQSPF30vLbcvL9ZygihUv71ALz8YUYEkF6bdY QOAUJjjVN2gRr6wKftDbFz4Vk7QrSSXO6kc8NpX0yZUtXPMU1oKnwAscZXVxHKE0abp2 VHp74y2ERqJwwc2hc+SQeCUDY+qAmfcxozH0e8Kjp4Yo+QjVBo+9X5xXcpYW5bVPV340 d8+Q== X-Gm-Message-State: AFq9FYLvTkmw4KUV5deBesUNxWPwNEsRvMrrobHeS8XRL3JDsYkcMso9 kaE/ddFHYZHARkoRXQwOKXwPRLOVAuw6JrEVgX8dh9oVXFJNGfG3wM6debkr3w== X-Gm-Gg: AYBFou28U6UHXwYEFcUomynd9TYfwKxfRqJIX4Gnbr+PW41c8Tc63GVrxXeIzmIEQBM jzlRhBoS4nCCUzfhBFSYMUags7hG4geqq8+nmw4iXnMkAwM9UYAL4ya9plZuKUIOI7dXxZ5/q9x Q2pMxBcK2hgAk8WwVFcdSgY1sc5OtzRnQrA3ppTnFrzOBahPS2AeQLRbSuqRPzM0XKCWTReOueO qNnIaNib7GGhNEliY9Oh4gMS4D+sU8UIxGTXWt85taIP0s8g6wiJw53+KjhqQyPh0FquwuG9ylz Qd2S9vU8uOAr24AsBpCOPR0PWKOhiMrV+lU/ZYdPWRhzb4QfsLpTGwYLDT3s9aXgVU+4gN5X++S VmOFIubqF/A3p7Ms9PzbB2xHuw/1gUZNOW8YAtTfToYkGVhLEr4WoF6QoesJoZbhwOn2yvUkQeB eN8Cp08Jnj7uUxy7n+VeQjYtpKi9oTBvnDE+K3lfwvAT3NJOP9aPLiEM37dkb7BM1ByQfIt3HTz 1Z7esQ= X-Received: by 2002:a17:90b:384b:b0:3a0:c276:1ec0 with SMTP id 98e67ed59e1d1-3ab3a9536cfmr1015101a91.28.1791529220883; Fri, 09 Oct 2026 00:00:20 -0700 (PDT) Message-ID: <7a2e8f6e-368f-4689-af53-057bac6beff2@gmail.com> Date: Fri, 9 Oct 2026 15:00:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support To: Dominik Csapak References: <20260914092015.125780-1-wukaiyang@loongfans.cn> <2082cf35-6e18-472f-ad33-a1629a482d69@proxmox.com> Content-Language: en-US From: Kaiyang Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EWMG7DG2QUL6ILFCG4E3ADBVN4NP2KMD X-Message-ID-Hash: EWMG7DG2QUL6ILFCG4E3ADBVN4NP2KMD X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com, Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded by https://lore.proxmox.com/pve-devel/20261009065813.109006-1-wukaiyang@loongfans.cn/ On 2026-09-23 16:55, Kaiyang Wu wrote: > Hi Dominik, > > Thanks for the clarification, I'll implement it in v3. > > Best, > Kaiyang > > On Tue, Sep 22, 2026, 19:38 Dominik Csapak > wrote: > > ok most code looks good to me, but I seemingly didn't properly > explained last time what i meant with ha integration: > > instead of letting Ha parse the guest state and act accordingly > my suggestion was more to let the user configure > the '-action panic=XX' commandline too > > there one can e.g. set 'exit-failure' which exits the qemu > process completely and ha would automatically notice it's down > during the next round and start it again, no need > to touch the ha code at all > > On 9/14/26 11:20 AM, Kaiyang Wu wrote: > > This patchset adds pvpanic device support to QEMU virtual machines to > > provide extra virtual machine status (guest-panicked) when virtual > > machines panic [0]. The HA stack now restarts a "started" VM when it > > panics. > > > > [0]: https://www.qemu.org/docs/master/specs/pvpanic.html > > > > > v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1- > wukaiyang@loongfans.cn/ devel/20260827103529.393388-1-wukaiyang@loongfans.cn/> > > > > Changes v1 -> v2: > > - Remove the pvpanic ISA device support to simplify the code > > - Move the pvpanic setting from Hardware to Options > > - Restart a HA-managed VM when it panics to restore the "started" > state > > > > > > qemu-server: > > > > Kaiyang Wu (1): > >    qemuserver: add pvpanic device > > > >   src/PVE/API2/Qemu.pm      |  1 + > >   src/PVE/QemuServer.pm     | 11 +++++++++++ > >   src/PVE/QemuServer/PCI.pm |  1 + > >   3 files changed, 13 insertions(+) > > > > > > docs: > > > > Kaiyang Wu (1): > >    qm: add document section for the pvpanic device > > > >   qm.adoc | 22 ++++++++++++++++++++++ > >   1 file changed, 22 insertions(+) > > > > > > manager: > > > > Kaiyang Wu (1): > >    ui: qemu: add pvpanic device support > > > >   www/manager6/qemu/Options.js | 20 ++++++++++++++++++++ > >   1 file changed, 20 insertions(+) > > > > > > ha-manager: > > > > Kaiyang Wu (2): > >    vm resource: return running status -1 for panicked VMs > >    lrm: stop and restart panicked VMs to keep the "started" state > > > >   src/PVE/HA/LRM.pm             | 9 ++++++++- > >   src/PVE/HA/Resources/PVEVM.pm | 5 ++++- > >   2 files changed, 12 insertions(+), 2 deletions(-) > > > >