From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C54241FF0B6 for ; Thu, 12 Nov 2026 12:08:03 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6FD442164F; Thu, 12 Nov 2026 12:08:00 +0100 (CET) Message-ID: <79a703dd-3893-4b73-b69c-0a0e847323fd@proxmox.com> Date: Thu, 12 Nov 2026 12:07:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid To: Thomas Lamprecht , =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20261103124831.139399-1-f.ebner@proxmox.com> <20261103124831.139399-6-f.ebner@proxmox.com> <63919262-8934-4709-84c0-e008cb6be0ed@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <63919262-8934-4709-84c0-e008cb6be0ed@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794481676901 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.276 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FKE6T442KBSDVMSG23HECTMEKYQYAEVH X-Message-ID-Hash: FKE6T442KBSDVMSG23HECTMEKYQYAEVH X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 12.11.26 um 12:00 PM schrieb Thomas Lamprecht: > Am 11.11.26 um 16:39 schrieb Michael Köppl: >> nit: the commit subject is over the limit of 72 > > fwiw, I'm pondering relaxing that rule for the subject, IMO its overly > limiting and "word golfing" to 72 or below is not exactly a productive > activity. For the body its less of a problem as one can have multiple > lines there anyway. > > Maybe something like: > - commit subject should be below 80cc and must be below 120cc > > Maybe even similar to our code rule: > - commit subject should be below 100cc and must be below 120cc > > That way we have a common guideline of using relatively concise > subjects without forcing brevity just for the sake of it and while > not allowing overly long subject that disrupt the git log etc > experience. > > What do you think? I.e., any strong feelings against hat or > preference? I'd just like to avoid redoing this more often. I would prefer a limit higher than 72. It can be quite useful for git oneline log if there is more context (prefixes), and more specific commit subjects.