From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4C4E386E04 for <pve-devel@lists.proxmox.com>; Tue, 28 Dec 2021 09:54:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C54721C58 for <pve-devel@lists.proxmox.com>; Tue, 28 Dec 2021 09:54:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7BD1121C4A for <pve-devel@lists.proxmox.com>; Tue, 28 Dec 2021 09:54:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4A0774529F for <pve-devel@lists.proxmox.com>; Tue, 28 Dec 2021 09:54:38 +0100 (CET) Message-ID: <78c84339-36c7-ab9f-6d5c-e8c75826e30d@proxmox.com> Date: Tue, 28 Dec 2021 09:54:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Aaron Lauterer <a.lauterer@proxmox.com> References: <20211221154830.2484781-1-a.lauterer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211221154830.2484781-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [android.com, readme.md] Subject: [pve-devel] applied: [PATCH v2 flutter_frontend] fix android splash screen logo X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 28 Dec 2021 08:54:39 -0000 On 21/12/2021 16:48, Aaron Lauterer wrote: > The new Android 12 splash screen will mask the logo / icon. See figure 2 > in [0]. This resulted in the current logo being cut off by the circular > mask, appearing broken. > > I created a new version, based on the stacked variant accounting for the > additional space around the logo needed for the mask. It is now stored > as a vector drawable. > The source svg file plus a template should we need to change that in the > future, are stored in the assets directory. > > The README.md also got an update to explain how to convert SVG files to > Android drawables. > > [0] https://developer.android.com/guide/topics/ui/splash-screen > > Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> > --- > > v1 -> v2: added source SVG files, updated README to explain how to > convert SVGs to Android vector drawables, commit message is now > hopefully clearer what happened and why we needed the change > > README.md | 20 +++ > .../main/res/drawable/launch_background.xml | 80 +++++++-- > assets/images/android_launch_background.svg | 112 ++++++++++++ > .../android_launch_background_template.svg | 162 ++++++++++++++++++ > 4 files changed, 363 insertions(+), 11 deletions(-) > create mode 100644 assets/images/android_launch_background.svg > create mode 100644 assets/images/android_launch_background_template.svg > > applied, fixing up the broken lines, slightly rewording the commit message and adding Dominik's T-b, thanks!