From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 flutter_frontend] fix android splash screen logo
Date: Tue, 28 Dec 2021 09:54:33 +0100 [thread overview]
Message-ID: <78c84339-36c7-ab9f-6d5c-e8c75826e30d@proxmox.com> (raw)
In-Reply-To: <20211221154830.2484781-1-a.lauterer@proxmox.com>
On 21/12/2021 16:48, Aaron Lauterer wrote:
> The new Android 12 splash screen will mask the logo / icon. See figure 2
> in [0]. This resulted in the current logo being cut off by the circular
> mask, appearing broken.
>
> I created a new version, based on the stacked variant accounting for the
> additional space around the logo needed for the mask. It is now stored
> as a vector drawable.
> The source svg file plus a template should we need to change that in the
> future, are stored in the assets directory.
>
> The README.md also got an update to explain how to convert SVG files to
> Android drawables.
>
> [0] https://developer.android.com/guide/topics/ui/splash-screen
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>
> v1 -> v2: added source SVG files, updated README to explain how to
> convert SVGs to Android vector drawables, commit message is now
> hopefully clearer what happened and why we needed the change
>
> README.md | 20 +++
> .../main/res/drawable/launch_background.xml | 80 +++++++--
> assets/images/android_launch_background.svg | 112 ++++++++++++
> .../android_launch_background_template.svg | 162 ++++++++++++++++++
> 4 files changed, 363 insertions(+), 11 deletions(-)
> create mode 100644 assets/images/android_launch_background.svg
> create mode 100644 assets/images/android_launch_background_template.svg
>
>
applied, fixing up the broken lines, slightly rewording the commit message and
adding Dominik's T-b, thanks!
prev parent reply other threads:[~2021-12-28 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 15:48 [pve-devel] " Aaron Lauterer
2021-12-22 8:31 ` Aaron Lauterer
2021-12-22 9:23 ` Dominik Csapak
2021-12-28 8:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c84339-36c7-ab9f-6d5c-e8c75826e30d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal