From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BFCE51FF136 for ; Mon, 18 May 2026 13:20:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31D14D151; Mon, 18 May 2026 13:20:48 +0200 (CEST) Message-ID: <78a4d126-36c2-41d2-b7f7-79b9dd0787d2@proxmox.com> Date: Mon, 18 May 2026 13:20:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: applied: [PATCH qemu-server v5 0/3] improve guest cleanup handling From: Dominik Csapak To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260515122437.3153051-1-d.csapak@proxmox.com> <177909704328.3037978.11473518831845296016.b4-ty@b4> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779103201573 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QVYM3QUPUAA2RTURPQY27SGHDNIUBNLT X-Message-ID-Hash: QVYM3QUPUAA2RTURPQY27SGHDNIUBNLT X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/18/26 1:08 PM, Dominik Csapak wrote: > > > On 5/18/26 12:46 PM, Thomas Lamprecht wrote: >> On Fri, 15 May 2026 14:23:03 +0200, Dominik Csapak wrote: >>> First we make the cleanup handling more consistent (1/3) >>> then we check explicitely for the backup lock to improve the error >>> message for stop backup mode (2/3) >>> and then we fix #7119 by waiting up to 30s for a possibly still running >>> guest to stop (e.g. this can occur when using usb passthrouh) (3/3) >>> >>> changes from v4: >>> * only warn after 10 seconds exactly once, to indicate this is not a >>>    normal situation >>> * drop the 'waiting for xx seconds' from warning message >>> >>> [...] >> >> Applied, thanks! >> >> [1/3] cleanup: refactor to make cleanup flow consistent >>        commit: 7d48d8ba6fff6cda24c00adc8aedc9c6b3b46e52 >> [2/3] qm cleanup: die early when encountering a running stop mode backup >>        commit: dd0fe2dfd6abe7a0af8faacfec755337a4d138be >> [3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 >> seconds >>        commit: adebb9715ce9cea0adca36f6684726b3a3a32a47 >> >> A few small fix-ups: >> > > thanks! > > >> - Bumped the preinst threshold from 9.1.12 to 9.1.13, the version this >>    actually landed in. >> - Added an optional skip_hookscript param to vm_stop_cleanup and pass it >>    true from QemuMigrate's source-side call - moving exec_hookscript into >>    vm_stop_cleanup would otherwise newly fire the hook on every migration >>    (the previous callsite was short-circuited there). Might be good to >> cross >>    check though. > > I'll test it shortly, but I think the post-stop hook was already > triggered in that case by the 'qm cleanup' call so now it won't be > triggered at all for live migrations? > > the 'post-stop' hook on the source side was AFAIR also intended to do > some manual cleanup when the qemu process was migrated away so > I think it's missing now. > > (but let me get back to that after testing with an older version) ok tested now and it did *not* get called before, so the current behavior is fine, thanks! > >> - Made the preinst marker write best-effort (touch ... || echo "..." >&2) >>    so a /run hiccup downgrades to a warning instead of aborting the >>    upgrade. >> - Renamed the marker to /run/qemu-server/force-legacy-cleanup; clearer >>    intent than 'use_old_cleanup'. >> - Shortened the commit message body to roughly half. > > > > >