From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 5C7551FF0AE for ; Tue, 01 Sep 2026 09:42:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6D7E1214BD; Tue, 01 Sep 2026 09:42:10 +0200 (CEST) Message-ID: <779c5435-669d-4212-a025-748aca9a2f56@proxmox.com> Date: Tue, 1 Sep 2026 09:42:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v3 08/13] fabrics: add IS-IS api types To: pve-devel@lists.proxmox.com References: <20260828113255.176546-1-g.goller@proxmox.com> <20260828113255.176546-9-g.goller@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788248524444 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.748 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UCRVVIJT5BWOACSMXJSUQULZIWZTG5YC X-Message-ID-Hash: UCRVVIJT5BWOACSMXJSUQULZIWZTG5YC X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-08-31 15:29, Gabriel Goller wrote: > On 31.08.2026 10:39, Hannes Laimer wrote: >> On 2026-08-28 13:32, Gabriel Goller wrote: >>> Add IS-IS api-types and add it to the protocol enum. Also make 'isisd' a >>> frr daemon managed by pve (This means we can enable and disable it). >>> >>> Signed-off-by: Gabriel Goller >>> --- >>> src/PVE/Network/SDN/Fabrics.pm | 51 ++++++++++++++++++++++++++++------ >>> src/PVE/Network/SDN/Frr.pm | 1 + >>> 2 files changed, 44 insertions(+), 8 deletions(-) >>> >>> diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm >>> index 4f842f1013ef..7a6e936bf735 100644 >>> --- a/src/PVE/Network/SDN/Fabrics.pm >>> +++ b/src/PVE/Network/SDN/Fabrics.pm >>> @@ -53,7 +53,7 @@ PVE::JSONSchema::register_standard_option( >>> { >>> description => "Type of configuration entry in an SDN Fabric section config", >>> type => 'string', >>> - enum => ['openfabric', 'ospf', 'wireguard', 'bgp'], >>> + enum => ['openfabric', 'ospf', 'wireguard', 'bgp', 'isis'], >>> }, >>> ); >>> >>> @@ -281,6 +281,41 @@ sub node_properties { >>> description => 'OpenFabric network interface', >>> optional => 1, >>> }, >>> + { >>> + type => 'array', >>> + 'instance-types' => ['isis'], >>> + items => { >>> + type => 'string', >>> + format => { >>> + name => { >>> + type => 'string', >>> + format => 'pve-iface', >>> + description => 'Name of the network interface', >>> + }, >>> + hello_multiplier => { >>> + type => 'integer', >>> + description => 'The hello_multiplier property of the interface', >>> + optional => 1, >>> + minimum => 2, >>> + maximum => 100, >>> + }, >>> + ip => { >>> + type => 'string', >>> + format => 'CIDRv4', >>> + description => 'IPv4 address for this node', >>> + optional => 1, >>> + }, >>> + ip6 => { >>> + type => 'string', >>> + format => 'CIDRv6', >>> + description => 'IPv6 address for this node', >>> + optional => 1, >>> + }, >>> + }, >>> + }, >>> + description => 'IS-IS network interface', >>> + optional => 1, >>> + }, >>> { >>> type => 'array', >>> 'instance-types' => ['ospf'], >>> @@ -438,7 +473,7 @@ sub node_properties { >>> }, >>> { >>> type => 'array', >>> - 'instance-types' => ['openfabric', 'ospf'], >>> + 'instance-types' => ['openfabric', 'ospf', 'isis'], >>> items => { >>> type => 'string', >>> enum => ['interfaces', 'ip', 'ip6'], >>> @@ -484,8 +519,8 @@ sub fabric_properties { >>> hello_interval => { >>> type => 'number', >>> 'type-property' => 'protocol', >>> - 'instance-types' => ['openfabric'], >>> - description => 'The hello_interval property for Openfabric', >>> + 'instance-types' => ['openfabric', 'isis'], >>> + description => 'The hello_interval property for Openfabric and IS-IS', >>> optional => 1, >>> minimum => 1, >>> maximum => 600, >>> @@ -493,8 +528,8 @@ sub fabric_properties { >>> csnp_interval => { >>> type => 'number', >>> 'type-property' => 'protocol', >>> - 'instance-types' => ['openfabric'], >>> - description => 'The csnp_interval property for Openfabric', >>> + 'instance-types' => ['openfabric', 'isis'], >>> + description => 'The csnp_interval property for Openfabric and IS-IS', >>> optional => 1, >>> minimum => 1, >>> maximum => 600, >>> @@ -511,7 +546,7 @@ sub fabric_properties { >>> type => 'string', >>> format => 'pve-sdn-prefix-list-id', >>> 'type-property' => 'protocol', >>> - 'instance-types' => ['ospf', 'openfabric'], >>> + 'instance-types' => ['ospf', 'openfabric', 'isis'], >>> description => >>> 'A prefix list that should be used for filtering routes that are to be installed into the kernel routing table', >>> optional => 1, >>> @@ -598,7 +633,7 @@ sub fabric_properties { >>> oneOf => [ >>> { >>> type => 'array', >>> - 'instance-types' => ['openfabric'], >>> + 'instance-types' => ['openfabric', 'isis'], >>> items => { >>> type => 'string', >>> enum => [ >>> diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm >>> index f81da325b1ef..729feb9e6cbd 100644 >>> --- a/src/PVE/Network/SDN/Frr.pm >>> +++ b/src/PVE/Network/SDN/Frr.pm >>> @@ -126,6 +126,7 @@ my $SDN_DAEMONS_DEFAULT = { >>> ospfd => 0, >>> fabricd => 0, >>> bgpd => 1, >>> + isisd => 1, >> >> with this enabled we get >> >> ``` >> commit failed session-id 34 on Unknown-FD-16 req-id 3 source-ds: candidate target-ds: running validate-only: 0: reason: 'Failed to create cfgdata: only inactive interfaces can be deleted' >> ``` >> >> when deleting either an IS-IS fabric (or controller), which causes a frr >> restart, this is just a warning in the apply task. So everything still >> works, but the the restart should not really be needed. >> >> This is basically [1], and got addresssed with [2], backporting them >> fixes this, but caused: >> >> ``` >> Error type: validation >> Error description: YANG error(s): >> Path: /frr-interface:lib/interface[name='dummy_isis0']/frr-isisd:isis >> Error: Mandatory node "area-tag" instance does not exist. >> ``` >> again emiting a warning and causing a frr restart (only in case of >> fabric though, controller is fine). This seems to be caused by `ip >> router `/`ipv6 router ` lines being first, so the running-config is >> emitted parent-first, but frr-reload deletes in emission order. Telling >> frr-reload to do `ip route ..` lines last seems to fix this, but I am not >> super sure if that's the right fix for this.. any thoughts on this @Gabriel? >> >> >> [1] https://github.com/FRRouting/frr/issues/20355 >> [2] https://github.com/FRRouting/frr/pull/20378 > > Yes, this is known it also happens with openfabric. I think we should backport > the PR and then fix the other error upstream (and backport it). I'll open a PR. > > Not a blocker IMO though. > also don't think so, more of a nice to have >>> }; >>> >>> =head3 set_daemon_status(\%daemons, $set_default) >>> -- >>> 2.47.3 >>> >>> >>> >>> >>>