From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D46E51FF165 for ; Wed, 29 Jan 2025 14:08:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 740B52A8AD; Wed, 29 Jan 2025 14:08:41 +0100 (CET) Message-ID: <775f73c4-4bea-4745-a6ae-04b3e2ba95fa@proxmox.com> Date: Wed, 29 Jan 2025 14:08:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Hannes Duerr References: <20250124144121.215130-1-h.duerr@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250124144121.215130-1-h.duerr@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v3 0/6] reduce setup steps for nvidia vgpu drivers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Looks mostly good and tested fine, but still a two comments: * IMHO patch 5/5 could be squashed into 3/5 (no need add code that gets changed immediately afterwards) * did you read thomas message for the service file last time around? https://lore.proxmox.com/pve-devel/fa1425a5-c8c8-4bed-814f-25169759e5e4@proxmox.com/ patch 4/5 does not have a commit message, so this would be good and as thomas said the sleep 5 could be replaced by a short script that checks the actual condition (IIRC if the correct nvidia daemon is loaded, I would have to check if you need that info (not sure if these are blockers though from @Thomas' side) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel