From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id F03C31FF37F
	for <inbox@lore.proxmox.com>; Thu, 18 Apr 2024 13:05:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 56CA01AE66;
	Thu, 18 Apr 2024 13:05:54 +0200 (CEST)
Message-ID: <76e37339-f31e-4660-b7fe-e23d96840e59@proxmox.com>
Date: Thu, 18 Apr 2024 13:05:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pve-devel@lists.proxmox.com
References: <20240418091650.51366-1-a.zeidler@proxmox.com>
Content-Language: en-US
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <20240418091650.51366-1-a.zeidler@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.141 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 POISEN_SPAM_PILL          0.1 Meta: its spam
 POISEN_SPAM_PILL_1        0.1 random spam to be learned in bayes
 POISEN_SPAM_PILL_3        0.1 random spam to be learned in bayes
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [report.pm, proxmox.com]
Subject: Re: [pve-devel] [PATCH manager 1/7] report: add kernel command line
 from current boot
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 4/18/24 11:16, Alexander Zeidler wrote:
> to get a first clue for debugging passthrough and similar issues, when
> no dmesg output has been provided yet.
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v2:
> * move away from dmesg base
> * only print kernel command line (boot times can be added by another patch)
> 
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062342.html
> 
> 
>  PVE/Report.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 53ffdcbb..a8c1cab9 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -31,6 +31,7 @@ my $init_report_cmds = sub {
>  	    cmds => [
>  		'hostname',
>  		'date -R',
> +		'cat /proc/cmdline',
>  		'pveversion --verbose',
>  		'cat /etc/hosts',
>  		'pvesubscription get',
Tested the whole patch series.
Looks good so far, especially the cmdline and APT information is nice to
have.

With the added APT information between subscription info, lscpu and
/cluster/resources, would it maybe make sense to move `pvesubscription
get` and `pvesh get /cluster/resources` next to each other, and `lscpu`
to the hardware section where we have all the `dmidecode` output, and
`lspci`?


Except for the `dmidecode -t16,17` command needing a space for
consistency, I'm fine with any of the additions.
So consider the whole series:

Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel