From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: m.federanko@proxmox.com
Cc: pbs-devel@lists.proxmox.com, w.bumiller@proxmox.com
Subject: Re: [PATCH proxmox-backup v2] fix #5247: relative paths in exclude patterns.
Date: Sat, 25 Apr 2026 20:59:22 +0200 [thread overview]
Message-ID: <769a6210-35b4-4dbe-9314-4e4ab045f2f2@proxmox.com> (raw)
In-Reply-To: <1fcc11ea-e66c-414e-a6f4-9ab43d0dae87@proxmox.com>
>> As for `--exclude`, I wonder we should just *bail* instead?
>>
>> Although that might "break" some automated
>> otherwise-working-but-probably-too-big backups, so we can't... (although
>> for `foo/../bar` it's *really* tempting...)
>
> I'm a bit undecided, maybe log a warning with a deprecation notice that
> this will lead to an error in the future? Same goes for the cli option
> now that I'm thinking about it.
I'd rather error on the side of caution and log a warning notice, even if
it's unlikely. As, e.g., some unmonitored backup CLI job not being able
to make backups after some (auto-)update pulled in the new version is
*far* from great.
prev parent reply other threads:[~2026-04-25 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 8:11 [PATCH proxmox-backup v2] fix #5247: relative paths in exclude patterns Manuel Federanko
2026-03-31 14:04 ` Wolfgang Bumiller
2026-03-31 14:48 ` Manuel Federanko
2026-04-25 18:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769a6210-35b4-4dbe-9314-4e4ab045f2f2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.federanko@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.