From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E9D4B7142F
 for <pve-devel@lists.proxmox.com>; Mon, 28 Jun 2021 17:59:22 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id D80482D7C8
 for <pve-devel@lists.proxmox.com>; Mon, 28 Jun 2021 17:58:52 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id ADB302D7B8
 for <pve-devel@lists.proxmox.com>; Mon, 28 Jun 2021 17:58:51 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7CE6744423
 for <pve-devel@lists.proxmox.com>; Mon, 28 Jun 2021 17:58:51 +0200 (CEST)
Message-ID: <75e8d07e-db14-112c-33c2-db630f517c9c@proxmox.com>
Date: Mon, 28 Jun 2021 17:58:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101
 Thunderbird/90.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lorenz Stechauner <l.stechauner@proxmox.com>
References: <20210624071618.21507-1-d.csapak@proxmox.com>
 <6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.471 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.765 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task
 listing
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2021 15:59:23 -0000

On 28.06.21 11:45, Lorenz Stechauner wrote:
> Tested VM & node task log. Works as expected
> 
> But found some minor inconveniences:
> * When a task is selected and the filter changes, therefore this task is not visible anymore, it is possible to click on the "view" button and see the previously selected task. Better behavior would be to clear the selection if the selected task is not visible anymore.
> * Improvement/suggestion: somehow show the task description to the user when selecting the task type (either combo box or "imgdel (Erase Data)" format?)
> 
> Tested-By: Lorenz Stechauner <l.stechauner@proxmox.com>

thanks for that. In addition to above I observed:

* no error-mask if the API call for the task list fails. E.g., I tested once with the
  original upid_get_status_type which results in a "500: Undefined subroutine &PVE::Tools::upid_get_status_type
  called at /usr/share/perl5/PVE/API2/Tasks.pm line 188." but the UI did not showed that, just stayed empty.

* Mark that a filter is active if the filter view is hidden, e.g., we could show a short
  text in the tbar at the left of the "Filter" button?

* Maybe add a "Clear All Filter" button? Could be useful if one set more than one field.