From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 0883061CC2 for <pve-devel@lists.proxmox.com>; Thu, 22 Oct 2020 15:07:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id F12712060D for <pve-devel@lists.proxmox.com>; Thu, 22 Oct 2020 15:07:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id D40E9205FD for <pve-devel@lists.proxmox.com>; Thu, 22 Oct 2020 15:07:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id A1FB245EDB; Thu, 22 Oct 2020 15:07:48 +0200 (CEST) To: Stefan Reiter <s.reiter@proxmox.com>, pve-devel@lists.proxmox.com References: <20201022121118.5504-1-s.reiter@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> Message-ID: <759f8b8c-9f30-4067-e003-9d7c7609d505@proxmox.com> Date: Thu, 22 Oct 2020 15:07:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201022121118.5504-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.478 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH 0/2] QEMU backup cancellation fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 22 Oct 2020 13:07:50 -0000 no code review, as i am not very qemu-coroutine savvy but i tested it and it solves my original problem short summary of it: starting a backup that runs into a timeout and then trying to cancel it resulted in a hanging qemu process and open backup task (on pbs side) that finished only when killing either end with these patches, that is solved and canceling the backup works as intended On 10/22/20 2:11 PM, Stefan Reiter wrote: > Two smaller bugfixes for qmp_backup_cancel, that would lead to VM hangs or > wrongly aborted backups. Sent as seperate patches to highlight the changes, but > can probably be squashed into some of our other patches as well (lmk if I should > do that). > > I also got dirty bitmap migrate working, but still needs some testing/cleanup. > I'd also like for upstream to give their final decision on the fix I sent, then > I'll confidently send that as well :) > > @Dominik: If you apply these two patches, can you still reproduce the hang on > abort? I'm not sure we experienced the 'same' hang. > > > Stefan Reiter (2): > PVE: Don't expect complete_cb to be called outside coroutine > PVE: Don't call job_cancel in coroutines > > pve-backup.c | 33 ++++++++++++++++++++++++++++----- > 1 file changed, 28 insertions(+), 5 deletions(-) >