From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C4C961FF137 for ; Tue, 17 Mar 2026 10:40:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EC1D66EA; Tue, 17 Mar 2026 10:40:56 +0100 (CET) Message-ID: <753dcbdb-6170-4076-b8b6-a1fb3d8907b1@proxmox.com> Date: Tue, 17 Mar 2026 10:40:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pve-devel] [PATCH qemu-server v5 8/9] deprecate freeze-fs-on-backup qga setting To: Thomas Lamprecht , Proxmox VE development discussion , Maximiliano Sandoval References: <20260105121702.20884-1-m.sandoval@proxmox.com> <20260105121702.20884-9-m.sandoval@proxmox.com> <9320e19a-94a9-452a-aedd-eea21a0572bf@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <9320e19a-94a9-452a-aedd-eea21a0572bf@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773740408436 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.562 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [agent.pm] Message-ID-Hash: GELLADQJSFX3OJY3OWTCTEXRX5N5EUY7 X-Message-ID-Hash: GELLADQJSFX3OJY3OWTCTEXRX5N5EUY7 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 16.03.26 um 10:49 PM schrieb Thomas Lamprecht: > Am 05.01.26 um 13:17 schrieb Maximiliano Sandoval: >> Signed-off-by: Maximiliano Sandoval >> --- >> src/PVE/QemuServer/Agent.pm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm >> index 7193d015..05ff4cae 100644 >> --- a/src/PVE/QemuServer/Agent.pm >> +++ b/src/PVE/QemuServer/Agent.pm >> @@ -35,8 +35,10 @@ our $agent_fmt = { >> optional => 1, >> default => 0, >> }, >> + # TODO Remove for Proxmox VE 10 >> 'freeze-fs-on-backup' => { >> - description => "Freeze/thaw guest filesystems on backup for consistency.", >> + description => "Deprecated: Use 'guest-fsfreeze' instead.\n\n" >> + . " Freeze/thaw guest filesystems on backup for consistency.", >> type => 'boolean', >> optional => 1, >> default => 1, > > why not just make this an alias for the new (superset) property? If we think most people set the property because the VM had issues with freezing, which are not actually limited to the backup case, then having it be an alias can be sensible. I do think this is the case, but it might still be surprising to some people. We could also wait until PVE 10 to have it become an alias or... > And you certainly *cannot* remove this in PVE 10, doing so will break > restoring previous backups! ...just translate the option to the more general one in restore_update_config_line() and/or parse_config(), then we could drop it from the schema.