From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 674B31FF15F
	for <inbox@lore.proxmox.com>; Mon,  2 Dec 2024 09:36:32 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id E676F117E2;
	Mon,  2 Dec 2024 09:36:35 +0100 (CET)
Message-ID: <748d0d02-9429-4a57-99af-5113ac0e2690@proxmox.com>
Date: Mon, 2 Dec 2024 09:36:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Hannes Duerr <h.duerr@proxmox.com>
References: <20241120112610.160234-1-h.duerr@proxmox.com>
 <20241120112610.160234-2-h.duerr@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20241120112610.160234-2-h.duerr@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.016 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 1/2]
 debian/control: adjust description and pve-manager dependency
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 11/20/24 12:26, Hannes Duerr wrote:
> remove the dependency of proxmox-dkms, since this package does not
> exist, and add the dependency of pve-manager, which should be installed
> with every reasonable Proxmox VE installation, so that the package can
> already be installed during the installation.
> 

i think that's in reverse? we don't need pve-manager here AFAICT,
but if we want a dependency somewhere, we'd want to add this package
as a dependency of pve-manager, no?

from the current state of this package I don't see a reason to depend on any pve/proxmox packages


> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
>   debian/control | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/debian/control b/debian/control
> index 1c19a50..f119bdc 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -8,11 +8,10 @@ Homepage: https://www.proxmox.com
>   
>   Package: proxmox-nvidia-vgpu-helper
>   Architecture: all
> -Depends: proxmox-dkms,
> +Depends: libapt-pkg-perl,
> +         pve-manager,
>            ${misc:Depends},
> -Description: Proxmox Nvidia vGPU systemd service
> - This package helps with the configuration of Nvidia vGPU
> - drivers by providing a systemd template service which
> +Description: Proxmox Nvidia vGPU helper script and systemd service
> + This package provides a script, that helps with installing all required
> + packages for the Nvidia vGPU driver, and also a systemd template service which
>    configures the option SRI-OV per pci-id
> -
> -



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel