From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 07DCF6210A for <pve-devel@lists.proxmox.com>; Wed, 19 Jan 2022 14:36:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F28D619458 for <pve-devel@lists.proxmox.com>; Wed, 19 Jan 2022 14:36:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5D3A619448 for <pve-devel@lists.proxmox.com>; Wed, 19 Jan 2022 14:36:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EA5345079 for <pve-devel@lists.proxmox.com>; Wed, 19 Jan 2022 14:36:10 +0100 (CET) Message-ID: <74302f7d-706e-e2fa-edb6-d7d5cc4e8b85@proxmox.com> Date: Wed, 19 Jan 2022 14:36:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20211008125226.56551-1-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211008125226.56551-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [RFC ha-manager] manage: handle edge case where a node gets stuck in 'fence' state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 19 Jan 2022 13:36:12 -0000 On 08.10.21 14:52, Fabian Ebner wrote: > If all services in 'fence' state are gone from a node (e.g. by > removing the services) before fence_node() was successful, a node > would get stuck in the 'fence' state. Avoid this by calling > fence_node() if the node is in 'fence' state, regardless of service > state. > > Reported in the community forum: > https://forum.proxmox.com/threads/ha-migration-stuck-is-doing-nothing.94469/ > > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > > Not really sure if this is worth it, because it's a hard to reach edge > case, but AFAICT there is no good way to get out of being stuck. What > would work is either of: > * Manually correcting the node state. > * Adding a service to the stuck node and triggering a fence > situation. > > An alternative would be to keep services in 'fence' state in the > manager state, even if they were removed from the config. But the > approach from this patch seemed a bit more robust: for example, it > will fix an already existing stuck state, rather than just avoid > creating one. > > src/PVE/HA/Manager.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > > applied, thanks! As also discussed off-list I noticed a related issue to a derived edge-case, that could cause trouble too. Spent some time in coming up with two tests covering your fixed situation plus also mine, expanding the capabilities of the test/simulation system slightly. https://git.proxmox.com/?p=pve-ha-manager.git;a=commit;h=ca2e547a7662467f9a08c54fa15b46825e3702e6 https://git.proxmox.com/?p=pve-ha-manager.git;a=commit;h=30fc7ceedb7f3047659f22d063cc16c94c20dd7a