Re: [PATCH manager] postinst: add nbd devices to global lvm filter.

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.07.26 um 9:03 AM schrieb Daniel Herzig:
> This patch adds nbd-devices to the global filter list of LVM for new

Nit: I'd prefer the more explicit "/dev/nbdX devices" or "kernel NBD
devices" rather than "nbd-devices". The hyphen makes it seems off IMHO.

> installation.

s/installation/installations/

> 
> This is to avoid clashes with existing VGs/LVs on the host system, if
> external disks mapped via the nbd kernel driver contain the same
> naming scheme (eg. nested Proxmox VE systems with LVM/ext4

s/eg./e.g./

> installation on an LVM/ext4 host).

You could add that some external backup solutions use these /dev/nbdX
devices, so there are quite a few setups in practice that would benefit.

Missing your Signed-off-by.

With that added and the comments addressed:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  debian/postinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/postinst b/debian/postinst
> index 924e078d..eb7f3356 100755
> --- a/debian/postinst
> +++ b/debian/postinst
> @@ -26,7 +26,7 @@ set_lvm_conf() {
>      export LVM_SUPPRESS_FD_WARNINGS=1
>  
>      OLD_VALUE="$(lvmconfig --typeconfig diff devices/global_filter || true)"
> -    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]'
> +    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|","r|/dev/nbd.*|"]'
>  
>      # update global_filter if:
>      # it is empty and there is no marker OR exactly the one we set before 8.1.4