From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 5A6C31FF16E
for <inbox@lore.proxmox.com>; Mon, 14 Apr 2025 16:53:17 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0004B3659D;
Mon, 14 Apr 2025 16:53:16 +0200 (CEST)
Date: Mon, 14 Apr 2025 16:53:13 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <742a6u3t5gkmikbafymq65ch4ezpnmcg6cydrb3ai5e64uyn4s@fohmrcrut5j4>
References: <20250411140557.1494389-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250411140557.1494389-1-d.csapak@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.082 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pdm-devel] applied: [PATCH datacenter-manager] server: connection:
improve error messages for remotes
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
applied, thanks
On Fri, Apr 11, 2025 at 04:05:57PM +0200, Dominik Csapak wrote:
> by including either the original error, or a notice that it timed out.
> That way, when we return the error over the API, the user can maybe
> better see what the actual problem is.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> server/src/connection.rs | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/server/src/connection.rs b/server/src/connection.rs
> index 1688fb3..201d65b 100644
> --- a/server/src/connection.rs
> +++ b/server/src/connection.rs
> @@ -747,13 +747,17 @@ macro_rules! try_request {
>
> if let Some(err) = last_err {
> log::error!("API client error (giving up) - {err:?}");
> + Err(proxmox_client::Error::Client(err))
> } else if timed_out {
> log::error!("API client timed out, no remotes reachable, giving up");
> + Err(proxmox_client::Error::Other(
> + "failed to perform API request: timed out",
> + ))
> + } else {
> + Err(proxmox_client::Error::Other(
> + "failed to perform API request: unknown error",
> + ))
> }
> -
> - Err(proxmox_client::Error::Other(
> - "failed to perform API request",
> - ))
> })
> };
> }
> --
> 2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel