From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5913B1FF136 for ; Mon, 09 Feb 2026 17:24:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8579AD003; Mon, 9 Feb 2026 17:25:28 +0100 (CET) Message-ID: <73f6389a-b5fb-428c-9862-2dfe5d788b98@proxmox.com> Date: Mon, 9 Feb 2026 17:25:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pve-devel] [PATCH pve-cluster 14/15] pmxcfs-rs: add Makefile for build automation To: Proxmox VE development discussion , Kefu Chai References: <20260106142440.2368585-1-k.chai@proxmox.com> <20260106142440.2368585-15-k.chai@proxmox.com> Content-Language: en-US From: Samuel Rufinatscha In-Reply-To: <20260106142440.2368585-15-k.chai@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.267 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OOOLUNSE62SMONXHG4TZFDLFQRWSB24H X-Message-ID-Hash: OOOLUNSE62SMONXHG4TZFDLFQRWSB24H X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/6/26 3:25 PM, Kefu Chai wrote: > Add Makefile with standard targets for building, testing, and linting: > - test: Run all workspace tests > - clippy: Lint code with clippy > - fmt: Check code formatting > - check: Full quality check (fmt + clippy + test) > - build: Build release version > - clean: Clean build artifacts > > This provides a consistent interface for building and testing the > Rust implementation. > > Signed-off-by: Kefu Chai > --- > src/pmxcfs-rs/.gitignore | 1 + > src/pmxcfs-rs/Makefile | 39 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 src/pmxcfs-rs/.gitignore > create mode 100644 src/pmxcfs-rs/Makefile > > diff --git a/src/pmxcfs-rs/.gitignore b/src/pmxcfs-rs/.gitignore > new file mode 100644 > index 00000000..ea8c4bf7 > --- /dev/null > +++ b/src/pmxcfs-rs/.gitignore > @@ -0,0 +1 @@ > +/target nit: Since patch 1 introduces the workspace, could we add the .gitignore there (and possibly fold this Makefile into that patch as well? > diff --git a/src/pmxcfs-rs/Makefile b/src/pmxcfs-rs/Makefile > new file mode 100644 > index 00000000..eaa96317 > --- /dev/null > +++ b/src/pmxcfs-rs/Makefile > @@ -0,0 +1,39 @@ > +.PHONY: all test lint clippy fmt check build clean help > + > +# Default target > +all: check build > + > +# Run all tests > +test: > + cargo test --workspace > + > +# Lint with clippy (using proxmox-backup style: only fail on correctness issues) > +clippy: > + cargo clippy --workspace -- -A clippy::all -D clippy::correctness > + > +# Check code formatting > +fmt: > + cargo fmt --all --check > + > +# Full quality check (format + lint + test) > +check: fmt clippy test > + > +# Build release version > +build: > + cargo build --workspace --release > + > +# Clean build artifacts > +clean: > + cargo clean > + > +# Show available targets > +help: > + @echo "Available targets:" > + @echo " all - Run check and build (default)" > + @echo " test - Run all tests" > + @echo " clippy - Run clippy linter" > + @echo " fmt - Check code formatting" > + @echo " check - Run fmt + clippy + test" > + @echo " build - Build release version" > + @echo " clean - Clean build artifacts" > + @echo " help - Show this help message"