From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4ABAF61FD7; Tue, 29 Sep 2020 05:54:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4062CAFE4; Tue, 29 Sep 2020 05:54:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A21F8AFD8; Tue, 29 Sep 2020 05:54:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6AAA44582C; Tue, 29 Sep 2020 05:54:20 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200916121419.3997-1-s.ivanov@proxmox.com> <20200916121419.3997-2-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <7386d18b-da4b-8384-a2d7-3277b1076f8b@proxmox.com> Date: Tue, 29 Sep 2020 05:54:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200916121419.3997-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.169 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [freedesktop.org, cryptsetup.target, zfs-import.target, multipathd.target] Subject: Re: [pve-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 29 Sep 2020 03:54:22 -0000 On 16.09.20 14:14, Stoiko Ivanov wrote: > [ --8<-- snip --8<-- ] > +diff --git a/etc/systemd/system/zfs-import@.service.in b/etc/systemd/s= ystem/zfs-import@.service.in > +new file mode 100644 > +index 000000000..2db9fdaab > +--- /dev/null > ++++ b/etc/systemd/system/zfs-import@.service.in > +@@ -0,0 +1,17 @@ > ++[Unit] > ++Description=3DImport ZFS pool %i > ++Documentation=3Dman:zpool(8) > ++DefaultDependencies=3Dno > ++Requires=3Dsystemd-udev-settle.service The after below can be OK, but why the require?? "Using this service is not recommended. [...]" -- https://www.freedesktop.org/software/systemd/man/systemd-udev-settle.s= ervice.html > ++After=3Dsystemd-udev-settle.service > ++After=3Dcryptsetup.target > ++After=3Dmultipathd.target > ++Before=3Dzfs-import.target > ++ > ++[Service] > ++Type=3Doneshot > ++RemainAfterExit=3Dyes > ++ExecStart=3D@sbindir@/zpool import -N -d /dev/disk/by-id -o cachefile= =3Dnone %I > ++ > ++[Install] > ++WantedBy=3Dzfs-import.target From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4ABAF61FD7; Tue, 29 Sep 2020 05:54:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4062CAFE4; Tue, 29 Sep 2020 05:54:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A21F8AFD8; Tue, 29 Sep 2020 05:54:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6AAA44582C; Tue, 29 Sep 2020 05:54:20 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200916121419.3997-1-s.ivanov@proxmox.com> <20200916121419.3997-2-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <7386d18b-da4b-8384-a2d7-3277b1076f8b@proxmox.com> Date: Tue, 29 Sep 2020 05:54:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200916121419.3997-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.169 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [freedesktop.org, cryptsetup.target, zfs-import.target, multipathd.target] Subject: Re: [pbs-devel] [pve-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 29 Sep 2020 03:54:22 -0000 On 16.09.20 14:14, Stoiko Ivanov wrote: > [ --8<-- snip --8<-- ] > +diff --git a/etc/systemd/system/zfs-import@.service.in b/etc/systemd/s= ystem/zfs-import@.service.in > +new file mode 100644 > +index 000000000..2db9fdaab > +--- /dev/null > ++++ b/etc/systemd/system/zfs-import@.service.in > +@@ -0,0 +1,17 @@ > ++[Unit] > ++Description=3DImport ZFS pool %i > ++Documentation=3Dman:zpool(8) > ++DefaultDependencies=3Dno > ++Requires=3Dsystemd-udev-settle.service The after below can be OK, but why the require?? "Using this service is not recommended. [...]" -- https://www.freedesktop.org/software/systemd/man/systemd-udev-settle.s= ervice.html > ++After=3Dsystemd-udev-settle.service > ++After=3Dcryptsetup.target > ++After=3Dmultipathd.target > ++Before=3Dzfs-import.target > ++ > ++[Service] > ++Type=3Doneshot > ++RemainAfterExit=3Dyes > ++ExecStart=3D@sbindir@/zpool import -N -d /dev/disk/by-id -o cachefile= =3Dnone %I > ++ > ++[Install] > ++WantedBy=3Dzfs-import.target