From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9EB97BDF6 for <pve-devel@lists.proxmox.com>; Wed, 13 Jul 2022 13:10:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8B541B76 for <pve-devel@lists.proxmox.com>; Wed, 13 Jul 2022 13:10:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 13 Jul 2022 13:10:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E414D420B1 for <pve-devel@lists.proxmox.com>; Wed, 13 Jul 2022 13:10:19 +0200 (CEST) Message-ID: <7361eb4f-e413-f428-df69-3d5ba347b2b2@proxmox.com> Date: Wed, 13 Jul 2022 13:10:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com> References: <20220602074206.814493-1-d.csapak@proxmox.com> <20220602074206.814493-3-d.csapak@proxmox.com> From: Fabian Ebner <f.ebner@proxmox.com> In-Reply-To: <20220602074206.814493-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v2 2/3] fix #4053: don't run vzdump jobs when they change from disabled->enabled X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 13 Jul 2022 11:10:21 -0000 Am 02.06.22 um 09:42 schrieb Dominik Csapak: > by updating the timestamp in the job state when enabled is changing > from 0 -> 1. We do it this way too in PBS for example, and is the more > sensible behaviour. > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> We've got a problem here. The state file is per-node, but a job can be for all nodes. When going from disabled to enabled, the job will still be executed on all nodes except the one that did the job config update. Even when a job is for a single node, the job update can happen from a different node. Issue reported in the community forum: https://forum.proxmox.com/threads/schedulded-backup-start-automaticly-when-edited.112055/