From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 58D4B1FF13F for ; Thu, 26 Mar 2026 16:02:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A69D617503; Thu, 26 Mar 2026 16:02:20 +0100 (CET) Message-ID: <727320c3-4316-450d-a129-3548b7e94b5f@proxmox.com> Date: Thu, 26 Mar 2026 16:01:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network 03/13] api2: add prefix list module To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260325094142.174364-1-s.hanreich@proxmox.com> <20260325094142.174364-18-s.hanreich@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260325094142.174364-18-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774537255787 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 637RHYISW25NAD5WSBUYE4INOBLYMU74 X-Message-ID-Hash: 637RHYISW25NAD5WSBUYE4INOBLYMU74 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-25 10:43, Stefan Hanreich wrote: > Contains the CRUD functionality for prefix lists: > > GET /prefix-lists - lists all prefix lists > GET /prefix-lists/ - get prefix list > POST /prefix-lists - create a new prefix list > PUT /prefix-lists/ - update prefix list > DELETE /prefix-lists/ - delete prefix list > > Signed-off-by: Stefan Hanreich > --- [..] > +__PACKAGE__->register_method({ > + name => 'list_prefix_lists', > + path => '', > + method => 'GET', > + permissions => { > + description => > + "Only returns prefix list entries where you have 'Sys.Audit' or 'Sys.Modify' permissions.", > + }, > + description => "List Prefix Lists", [..] > + code => sub { > + my ($param) = @_; > + > + my $pending = extract_param($param, 'pending'); > + my $running = extract_param($param, 'running'); > + > + my $digest; > + my $prefix_lists; > + > + if ($pending) { > + my $current_config = PVE::Network::SDN::PrefixLists::config()->list(); > + my $running_config = PVE::Network::SDN::PrefixLists::config(1)->list(); > + > + my $pending_prefix_lists = PVE::Network::SDN::pending_config( > + $running_config, > + $current_config, ``` my $running_objects = $running_cfg->{$type}->{ids}; my $config_objects = $cfg->{ids}; ``` is how `pending_config(..)` accesses these two, since `->list()` just returns a hash we have to wrap these two ``` - $running_config, - $current_config, + { 'route-maps' => { ids => $running_route_maps } }, + { ids => $current_route_maps }, ``` > + 'prefix-lists', > + ); > + > + $digest = $current_config->digest(); > + $prefix_lists = $pending_prefix_lists->{ids} > + } elsif ($running) { [..]