From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4E3911FF17A for ; Tue, 28 Oct 2025 13:17:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F10419C62; Tue, 28 Oct 2025 13:18:16 +0100 (CET) Message-ID: <7250f495-0892-44c9-9c20-90ef937527d6@proxmox.com> Date: Tue, 28 Oct 2025 13:17:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Friedrich Weber References: <20251024122705.93761-1-f.weber@proxmox.com> <20251024122705.93761-2-f.weber@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251024122705.93761-2-f.weber@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761653850457 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm] Subject: Re: [pve-devel] [PATCH pve-storage 1/2] plugin: map/activate volume: allow callers to pass hints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 24.10.25 um 2:27 PM schrieb Friedrich Weber: > +sub verify_hints { > + my ($hints, $noerr) = @_; > + > + return if !defined($hints); > + > + eval { PVE::JSONSchema::validate($hints, $PVE::Storage::Plugin::hints_format); }; > + my $err = $@; > + > + return $hints if !$err; > + return if $noerr; > + > + die "hints are not valid: $@"; Nit: I'd use "internal error - storage hints ..." to reduce potential for confusion. > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 8acd214..2c72179 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -59,6 +59,19 @@ cfs_register_file( > sub { __PACKAGE__->write_config(@_); }, > ); > > +our $hints_properties = { > + 'guest-ostype' => { > + type => 'string', > + optional => 1, > + }, I'd rather have this be an explicit "guest-is-windows" boolean. The storage layer should not have any idea of how to parse guest OS types. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel