From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D20831FF15E for ; Tue, 20 Jan 2026 14:24:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E63D51047E; Tue, 20 Jan 2026 14:24:56 +0100 (CET) Message-ID: <72072299-6e64-4e12-9c4b-28d7c41d2a63@proxmox.com> Date: Tue, 20 Jan 2026 14:24:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20260120113351.22921-1-h.laimer@proxmox.com> From: Nicolas Frey Content-Language: en-US In-Reply-To: <20260120113351.22921-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768915409502 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.777 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [environment.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" missed this when I added datastore-level thread settings, thanks! Reviewed-by: Nicolas Frey On 1/20/26 12:33 PM, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/api2/backup/environment.rs | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs > index bd9c5211..3c624b18 100644 > --- a/src/api2/backup/environment.rs > +++ b/src/api2/backup/environment.rs > @@ -799,10 +799,13 @@ impl BackupEnvironment { > false, > move |worker| { > worker.log_message("Automatically verifying newly added snapshot"); > - > - // FIXME: update once per-datastore read/verify settings > - // are available to not use default amount of threads here > - let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?; > + let thread_settings = datastore.thread_settings().clone(); > + let verify_worker = VerifyWorker::new( > + worker.clone(), > + datastore, > + thread_settings.verify_job_read_threads, > + thread_settings.verify_job_verify_threads, > + )?; > if !verify_worker.verify_backup_dir_with_lock( > &backup_dir, > worker.upid().clone(), _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel