From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B53361FF140 for ; Fri, 13 Mar 2026 15:45:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2AD8A64FE; Fri, 13 Mar 2026 15:45:47 +0100 (CET) Message-ID: <71e85e3e-b24c-497f-99ff-d685759e3f78@proxmox.com> Date: Fri, 13 Mar 2026 15:45:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v5 12/20] partially fix #6563: ui: expose s3 rrd charts in datastore summary To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-26-c.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260311130823.724888-26-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773413074198 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.989 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QJ4S55Z6U2CR4JYNHDAQARUNSZP7PEJP X-Message-ID-Hash: QJ4S55Z6U2CR4JYNHDAQARUNSZP7PEJP X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-11 14:09, Christian Ebner wrote: > Show the total request counts per method as well as the total and > derived upload/download s3 api statistics as rrd charts. > > This partially fixes issue 6563, further information such as usage > statistics for the s3 backend will be implemented. > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6563 > Signed-off-by: Christian Ebner > --- [..] > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('S3 API download/upload rate (bytes/second)'), > + fields: ['s3/downloaded', 's3/uploaded'], > + fieldTitles: [gettext('Upload'), gettext('Download')], should be swapped :) > + bind: { > + visible: '{showS3Stats}', > + }, > + }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('S3 API total download/upload (bytes)'), > + fields: ['s3/total/downloaded', 's3/total/uploaded'], > + fieldTitles: [gettext('Download'), gettext('Upload')], > + bind: { > + visible: '{showS3Stats}', > + }, > + }, > { > xtype: 'proxmoxRRDChart', > title: gettext('Storage usage (bytes)'),