[PATCH storage v2 5/7] zfsnvme: accept activation hints from storage API

[Joaquin Varela <joaquinvarela@neatech.ar>]

Match the current activate_volume callback signature by accepting the
optional activation hints argument. Keep the existing snapshot rejection
semantics and add a focused compatibility test.

Signed-off-by: Joaquin Varela <joaquinvarela@neatech.ar>
---
 src/PVE/Storage/ZFSNVMePlugin.pm | 10 +++++++++-
 src/test/zfsnvme_test.pm         | 16 ++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/ZFSNVMePlugin.pm b/src/PVE/Storage/ZFSNVMePlugin.pm
index 6513df0..21fa00d 100644
--- a/src/PVE/Storage/ZFSNVMePlugin.pm
+++ b/src/PVE/Storage/ZFSNVMePlugin.pm
@@ -772,7 +772,15 @@ sub qemu_blockdev_options($class, $scfg, $storeid, $volname, $machine_version, $
     return { driver => 'host_device', filename => $path };
 }
 
-sub activate_volume($class, $storeid, $scfg, $volname, $snapname, $cache = undef) {
+sub activate_volume(
+    $class,
+    $storeid,
+    $scfg,
+    $volname,
+    $snapname,
+    $cache = undef,
+    $hints = undef,
+) {
     die "unable to activate snapshot from remote zfs storage\n" if $snapname;
     my ($path) = $class->path($scfg, $volname, $storeid);
     if (!-b $path) {
diff --git a/src/test/zfsnvme_test.pm b/src/test/zfsnvme_test.pm
index e06ac76..128ebf1 100644
--- a/src/test/zfsnvme_test.pm
+++ b/src/test/zfsnvme_test.pm
@@ -203,6 +203,22 @@ is_deeply(
     'uses the QEMU host_device driver',
 );
 
+eval {
+    PVE::Storage::ZFSNVMePlugin->activate_volume(
+        'nvmetest',
+        $scfg,
+        'vm-100-disk-0',
+        'snapshot-with-hints',
+        {},
+        { 'guest-type' => 'qemu' },
+    );
+};
+like(
+    $@,
+    qr/unable to activate snapshot from remote zfs storage/,
+    'activate_volume accepts the current storage API hints argument',
+);
+
 my $lio_mock = Test::MockModule->new('PVE::Storage::LunCmd::LIO');
 my @provider_args;
 $lio_mock->redefine(
-- 
2.54.0.windows.1